Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use the correct error channel #2164

Merged
merged 1 commit into from Mar 3, 2018

Conversation

ElvinEfendi
Copy link
Member

What this PR does / why we need it:
I yet to test this change but I could not find any other reference to done in the code base.

Which issue this PR fixes:
n/a

Special notes for your reviewer:
n/a

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 3, 2018
@k8s-reviewable
Copy link

This change is Reviewable

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 3, 2018
@codecov-io
Copy link

Codecov Report

Merging #2164 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2164      +/-   ##
==========================================
+ Coverage   36.44%   36.45%   +<.01%     
==========================================
  Files          69       69              
  Lines        4862     4861       -1     
==========================================
  Hits         1772     1772              
+ Misses       2820     2819       -1     
  Partials      270      270
Impacted Files Coverage Δ
internal/ingress/controller/nginx.go 3.95% <0%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e07e06...62592ae. Read the comment docs.

@aledbf
Copy link
Member

aledbf commented Mar 3, 2018

/approve

@aledbf
Copy link
Member

aledbf commented Mar 3, 2018

@ElvinEfendi thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@aledbf aledbf merged commit 38b35c2 into kubernetes:master Mar 3, 2018
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 3, 2018
@ElvinEfendi ElvinEfendi deleted the use-correct-error-channel branch March 3, 2018 14:38
@aledbf aledbf added this to done in nginx 0.12.0 Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants