Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Assert or install go-bindata before incanting #2456

Merged
merged 1 commit into from May 1, 2018
Merged

Assert or install go-bindata before incanting #2456

merged 1 commit into from May 1, 2018

Conversation

andrewloux
Copy link
Contributor

What this PR does / why we need it:

  • Small fix to make sure go-bindata exists or is installed before running the code-generator task.

Special notes for your reviewer:
cc @aledbf @ElvinEfendi

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 30, 2018
@aledbf aledbf self-requested a review April 30, 2018 18:29
@aledbf
Copy link
Member

aledbf commented Apr 30, 2018

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 30, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, andrewlouis93

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2018
@aledbf
Copy link
Member

aledbf commented Apr 30, 2018

@andrewlouis93 I will try to remove the go-bindata dependency because we use that only for testing.

@andrewloux
Copy link
Contributor Author

Sounds good, @aledbf - feel free to close this PR if you happen to get around to it soon :)

@aledbf aledbf added this to In Progress in 0.15.0 Apr 30, 2018
@k8s-ci-robot k8s-ci-robot merged commit 278c055 into kubernetes:master May 1, 2018
@aledbf aledbf moved this from In Progress to done in 0.15.0 May 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aledbf aledbf Awaiting requested review from aledbf

Assignees

@aledbf aledbf

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
No open projects
0.15.0
  
done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andrewloux @aledbf @k8s-ci-robot