Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable reuse-port by default #2897

Merged
merged 1 commit into from Aug 5, 2018

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Aug 4, 2018

No description provided.

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 4, 2018
@aledbf aledbf added this to In Progress in 0.18.0 Aug 4, 2018
@codecov-io
Copy link

Codecov Report

Merging #2897 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2897      +/-   ##
==========================================
+ Coverage   47.55%   47.58%   +0.02%     
==========================================
  Files          76       76              
  Lines        5484     5485       +1     
==========================================
+ Hits         2608     2610       +2     
+ Misses       2542     2540       -2     
- Partials      334      335       +1
Impacted Files Coverage Δ
internal/ingress/controller/config/config.go 98.29% <100%> (+0.01%) ⬆️
internal/watch/file_watcher.go 84.61% <0%> (+3.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38207e8...1d00a5c. Read the comment docs.

@ElvinEfendi
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 5, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9b3207d into kubernetes:master Aug 5, 2018
@aledbf aledbf moved this from In Progress to done in 0.18.0 Aug 5, 2018
@aledbf aledbf deleted the enable-reuseport branch August 5, 2018 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants