[wip] Lua tracing

[ElvinEfendi]

What this PR does / why we need it:

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ElvinEfendi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ElvinEfendi]

I see

2019/02/20 14:40:54 [error] 42#42: *374 failed to expand opentracing_context_ for request 0000564FD8E6D060: no OpenTracingContext attached to request, client: 172.17.0.1, server: example.com, request: "GET /echo HTTP/1.1", host: "example.com"
2019/02/20 14:40:54 [warn] 42#42: *374 [lua] balancer.lua:224: trace_function(): ngx.var.opentracing_binary_context is empty, client: 172.17.0.1, server: example.com, request: "GET /echo HTTP/1.1", host: "example.com"

in the logs for my example app, this happens in rewrite phase where opentracing hasn't run yet, it creates opentracing context only at preaccess phase, which is after rewrite: https://github.com/opentracing-contrib/nginx-opentracing/blob/9cde691471eee8152484462f748486f595007464/opentracing/src/ngx_http_opentracing_module.cpp#L172

[ElvinEfendi]

But it does work for anything after preaccess phase and looks like

[ElvinEfendi]

I'll revert this, this is only so that I can use locally build base image using

BASEIMAGE=quay.io/kubernetes-ingress-controller/nginx-amd64:0.78 make dev-env

where I built quay.io/kubernetes-ingress-controller/nginx-amd64:0.78 locally based on #3782

[aledbf]

@ElvinEfendi what's missing to merge the PR?

[ElvinEfendi]

@aledbf check opentracing-contrib/nginx-opentracing#85

[fejta-bot]

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/check-cla

[ElvinEfendi]

Now that opentracing-contrib/nginx-opentracing#98 is merged, I'm going to resume this work to see if that helps.

[aledbf]

@ElvinEfendi did you test this with the new image?

[k8s-ci-robot]

@ElvinEfendi: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-ingress-nginx-e2e-1-15	ef9d96b	link	/test pull-ingress-nginx-e2e-1-15
pull-ingress-nginx-lualint	ef9d96b	link	/test pull-ingress-nginx-lualint

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@ElvinEfendi: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

@fejta-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.