Add opentracing operation name settings

[JorritSalverda]

What this PR does / why we need it:

In order to set custom span names for server and location span use the following config items in the configmap:

opentracing-operation-name: "HTTP $request_method $uri"
opentracing-location-operation-name: "HTTP $request_method $uri"

Which issue this PR fixes:

fixes #4116

[k8s-ci-robot]

Hi @JorritSalverda. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: JorritSalverda
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: aledbf

If they are not already assigned, you can assign the PR to them by writing /assign @aledbf in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[JorritSalverda]

/assign @aledbf

[ElvinEfendi]

@JorritSalverda thanks for the PR, please write e2e tests to cover these new functionality.

[JorritSalverda]

@ElvinEfendi I've added tests confirming presence of the directives in the generated config. I guess it's easiest to add tests for #4117 when this one's merged.

[aledbf]

/ok-to-test

[aledbf]

@JorritSalverda please rebase and squash the commits

[codecov-io]

Codecov Report

Merging #4118 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4118      +/-   ##
==========================================
+ Coverage   57.63%   57.64%   +<.01%     
==========================================
  Files          87       87              
  Lines        6463     6459       -4     
==========================================
- Hits         3725     3723       -2     
  Misses       2307     2307              
+ Partials      431      429       -2

Impacted Files	Coverage Δ
internal/ingress/controller/config/config.go	98.56% <ø> (ø)	⬆️
internal/watch/file_watcher.go	80.76% <0%> (-3.85%)	⬇️
internal/ingress/controller/controller.go	46.56% <0%> (+0.05%)	⬆️
...ternal/ingress/annotations/sessionaffinity/main.go	57.14% <0%> (+1.87%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e76418c...f77eaae. Read the comment docs.

[JorritSalverda]

@aledbf I've squashed and rebased. I'm not fully clear on why the tests have failed, whether it's an error in my tests or the test run experiences timeouts for another reason.

[aledbf]

I'm not fully clear on why the tests have failed, whether it's an error in my tests or the test run experiences timeouts for another reason

The errors are related to your tests. (you can check the failures https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/ingress-nginx/4118/pull-ingress-nginx-e2e-1-13/1136971198354165760)

[aledbf]

@JorritSalverda friendly ping

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[k8s-ci-robot]

@JorritSalverda: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-ingress-nginx-e2e-1-13	f77eaae	link	/test pull-ingress-nginx-e2e-1-13
pull-ingress-nginx-e2e-1-14	f77eaae	link	/test pull-ingress-nginx-e2e-1-14
pull-ingress-nginx-e2e-1-15	f77eaae	link	/test pull-ingress-nginx-e2e-1-15
pull-ingress-nginx-e2e-1-16	f77eaae	link	/test pull-ingress-nginx-e2e-1-16
pull-ingress-nginx-e2e-1-17	f77eaae	link	/test pull-ingress-nginx-e2e-1-17

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[aledbf]

@JorritSalverda please reopen when you can fix the e2e issues