New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add canary-by-cookie-value annotation #4200
Add canary-by-cookie-value annotation #4200
Conversation
Hi @s-shirayama. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: s-shirayama The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @aledbf |
a7569af
to
a458189
Compare
a458189
to
19faa9b
Compare
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Stale issues rot after 30d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
Rotten issues close after 30d of inactivity. Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
@fejta-bot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What this PR does / why we need it:
This PR adds new annotation
canary-by-cookie-value
to enable canary release with specific cookie's value.It's similar with an existing annotation
canary-by-header-value
, but the difference is thatcanary-by-cookie-value
will be used on regular expression matching.Original motivation to add this annotation is that we'd like to have canary release for web application and want to lock version for each user. If this PR is merged, this can be possible by using session cookie's value.
Which issue this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close that issue when PR gets merged): fixes #N/A
Special notes for your reviewer:
I have concern about the naming of annotation.
canary-by-header-value
is not treated as regular expression butcanary-by-cookie-value
is so, even though the name is similar. If it's confusing, it can be different annotation name. Let me hear your opinion.