Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate ingress definitions from extensions to networking.k8s.io #4827

Merged
merged 7 commits into from Dec 13, 2019

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Dec 12, 2019

What this PR does / why we need it:

Fixes the current failures in e2e tests. Since k8s v1.16 is not possible to create ingress objects from the extension group.

Which issue this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged): fixes #

Special notes for your reviewer:

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 12, 2019
@codecov-io
Copy link

codecov-io commented Dec 12, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@be19071). Click here to learn what that means.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #4827   +/-   ##
=========================================
  Coverage          ?   58.46%           
=========================================
  Files             ?       88           
  Lines             ?     6719           
  Branches          ?        0           
=========================================
  Hits              ?     3928           
  Misses            ?     2362           
  Partials          ?      429
Impacted Files Coverage Δ
internal/ingress/status/status.go 70.98% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be19071...5c30820. Read the comment docs.

@aledbf
Copy link
Member Author

aledbf commented Dec 13, 2019

/retest

1 similar comment
@aledbf
Copy link
Member Author

aledbf commented Dec 13, 2019

/retest

@aledbf
Copy link
Member Author

aledbf commented Dec 13, 2019

/retest

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 13, 2019
@ElvinEfendi
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ElvinEfendi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 351ce53 into kubernetes:master Dec 13, 2019
@aledbf aledbf deleted the update-versions branch December 13, 2019 14:11
@aledbf aledbf added this to done in 0.27.0 Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
No open projects
0.27.0
  
done
Development

Successfully merging this pull request may close these issues.

None yet

5 participants