Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to nginx again #4863

Merged
merged 3 commits into from Jan 4, 2020
Merged

Switch to nginx again #4863

merged 3 commits into from Jan 4, 2020

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Dec 26, 2019 •
edited

What this PR does / why we need it:

  • The latest release from OpenResty is almost four months old.
  • It still uses NGINX 1.15.8.
  • There is no clear timeline for the next release or sync with 1.17.7 (security issues with error_page directive)
  • Use a multi-stage build to simplify the cleanup process of the source artifacts and packages.
  • Why the migration to alpine Linux? Because it removes all vulnerabilities from the image.
  • Reduces the size of the docker image in ~90MB

@aledbf aledbf added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 26, 2019
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels Dec 26, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 26, 2019
@codecov-io
Copy link

codecov-io commented Dec 26, 2019 •
edited

Codecov Report

Merging #4863 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4863   +/-   ##
=======================================
  Coverage   58.37%   58.37%           
=======================================
  Files          88       88           
  Lines        6720     6720           
=======================================
  Hits         3923     3923           
  Misses       2369     2369           
  Partials      428      428

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aba58d6...048ce1a. Read the comment docs.

@aledbf aledbf changed the title Switch nginx Switch to nginx again Dec 26, 2019
@aledbf aledbf added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 26, 2019
@aledbf aledbf added this to In Progress in 0.27.0 Dec 26, 2019
@aledbf
Copy link
Member Author

aledbf commented Dec 27, 2019

/retest

3 similar comments
@aledbf
Copy link
Member Author

aledbf commented Dec 27, 2019

/retest

@aledbf
Copy link
Member Author

aledbf commented Dec 27, 2019

/retest

@aledbf
Copy link
Member Author

aledbf commented Dec 27, 2019

/retest

@aledbf
Copy link
Member Author

aledbf commented Dec 27, 2019

/retest

@aledbf
Copy link
Member Author

aledbf commented Dec 27, 2019

/retest

1 similar comment
@aledbf
Copy link
Member Author

aledbf commented Dec 27, 2019

/retest

@aledbf
Copy link
Member Author

aledbf commented Dec 27, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Dec 27, 2019
@aledbf
Copy link
Member Author

aledbf commented Dec 28, 2019

/retest

2 similar comments
@aledbf
Copy link
Member Author

aledbf commented Dec 28, 2019

/retest

@aledbf
Copy link
Member Author

aledbf commented Dec 28, 2019

/retest

@aledbf
Copy link
Member Author

aledbf commented Dec 28, 2019

/retest

@aledbf
Copy link
Member Author

aledbf commented Dec 29, 2019

/retest

2 similar comments
@aledbf
Copy link
Member Author

aledbf commented Dec 29, 2019

/retest

@aledbf
Copy link
Member Author

aledbf commented Dec 29, 2019

/retest

@aledbf aledbf mentioned this pull request Dec 29, 2019
Closed
@aledbf aledbf merged commit eb3fd57 into kubernetes:master Jan 4, 2020
@aledbf aledbf deleted the switch-nginx branch January 4, 2020 14:08
@aledbf aledbf moved this from In Progress to done in 0.27.0 Jan 4, 2020
@edmondsw edmondsw mentioned this pull request Apr 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmluciano cmluciano Awaiting requested review from cmluciano

@ElvinEfendi ElvinEfendi Awaiting requested review from ElvinEfendi

Assignees

@ElvinEfendi ElvinEfendi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
No open projects
0.27.0
  
done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aledbf @k8s-ci-robot @codecov-io @ElvinEfendi