Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check chart controller image tag #5252

Merged
merged 1 commit into from
Mar 16, 2020
Merged

Check chart controller image tag #5252

merged 1 commit into from
Mar 16, 2020

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Mar 15, 2020 •
edited
Loading

What this PR does / why we need it:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

xref: #5161

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Mar 15, 2020
aledbf
aledbf commented Mar 15, 2020
View reviewed changes
charts/ingress-nginx/templates/check.yaml Outdated
@@ -0,0 +1 @@
{{ include "isControllerTagValid" . | required "controller container image tag should be 0.27.0 or higher" }}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChiefAlexander this does not work but contains the idea of tag validation. Any idea how this can be done?

ChiefAlexander
ChiefAlexander suggested changes Mar 16, 2020
View reviewed changes
Copy link
Contributor

@ChiefAlexander ChiefAlexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, we would also flex this upon appVersion which is defined in the chart.yaml. This way we only have to update that value to bump the image version.
Todo that here we will have to do some logic around subtracting 3 minor versions. I am not sure off the top of my head how that could be accomplished.

charts/ingress-nginx/templates/_helpers.tpl Outdated Show resolved Hide resolved
charts/ingress-nginx/templates/check.yaml Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 16, 2020
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 16, 2020
@aledbf aledbf changed the title WIP: Check chart controller image tag Check chart controller image tag Mar 16, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 16, 2020
@ChiefAlexander
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 16, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, ChiefAlexander

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit f19d52b into kubernetes:master Mar 16, 2020
@aledbf aledbf added this to done in 0.31.0 Mar 16, 2020
@aledbf aledbf deleted the tag branch March 16, 2020 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChiefAlexander ChiefAlexander ChiefAlexander requested changes

@ElvinEfendi ElvinEfendi Awaiting requested review from ElvinEfendi

Assignees

@ChiefAlexander ChiefAlexander

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
No open projects
0.31.0
  
done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aledbf @ChiefAlexander @k8s-ci-robot