Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default-type as a configurable for default_type #5745

Merged
merged 1 commit into from Jun 21, 2020
Merged

Add default-type as a configurable for default_type #5745

merged 1 commit into from Jun 21, 2020

Conversation

MengqiWu
Copy link
Contributor

What this PR does / why we need it:

"default_type" is a nginx directive, ingress-nginx hard coded it as "text/html", some times we need change it for compatibility

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot
Copy link
Contributor

Hi @MengqiWu. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 19, 2020
@fejta-bot
Copy link

Unknown CLA label state. Rechecking for CLA labels.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/check-cla

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 19, 2020
aledbf
aledbf reviewed Jun 19, 2020
View reviewed changes
Copy link
Member

@aledbf aledbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 19, 2020
@aledbf
Copy link
Member

aledbf commented Jun 19, 2020

/ok-to-test

@MengqiWu
Copy link
Contributor Author

/retest

@aledbf aledbf added this to In Progress in 0.34.0 Jun 20, 2020
@MengqiWu
Copy link
Contributor Author

/retest

3 similar comments
@MengqiWu
Copy link
Contributor Author

/retest

@MengqiWu
Copy link
Contributor Author

/retest

@aledbf
Copy link
Member

aledbf commented Jun 21, 2020

/retest

aledbf
aledbf reviewed Jun 21, 2020
View reviewed changes
docs/user-guide/nginx-configuration/configmap.md Outdated
@@ -183,6 +183,7 @@ The following table shows a configuration option's name, type, and the default v
|[block-user-agents](#block-user-agents)|[]string|""|
|[block-referers](#block-referers)|[]string|""|
|[proxy-ssl-location-only](#proxy-ssl-location-only)|bool|"false"|
|[default-type](#default-type)|[]string|"text/html"|
Copy link
Member

@aledbf aledbf Jun 21, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this setting is just a string, not an array. Once you change this the PR lgtm

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks，i fixed it

@aledbf
Copy link
Member

aledbf commented Jun 21, 2020

/lgtm
/approve

@aledbf
Copy link
Member

aledbf commented Jun 21, 2020

@MengqiWu thanks!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 21, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, MengqiWu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 21, 2020
@MengqiWu
Copy link
Contributor Author

/retest

1 similar comment
@MengqiWu
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 687e433 into kubernetes:master Jun 21, 2020
@aledbf aledbf moved this from In Progress to done in 0.34.0 Jun 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aledbf aledbf aledbf left review comments

@ElvinEfendi ElvinEfendi Awaiting requested review from ElvinEfendi

Assignees

@aledbf aledbf

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
No open projects
0.34.0
  
done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@MengqiWu @k8s-ci-robot @fejta-bot @aledbf