Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor extraction of ingress pod details #6480

Merged
merged 1 commit into from Nov 19, 2020
Merged

Conversation

aledbf
Copy link
Member

@aledbf aledbf commented Nov 14, 2020

What this PR does / why we need it:

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 14, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2020
@codecov-io
Copy link

Codecov Report

Merging #6480 (edb9002) into master (ca7db0e) will decrease coverage by 0.06%.
The diff coverage is 44.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6480      +/-   ##
==========================================
- Coverage   55.81%   55.75%   -0.07%     
==========================================
  Files          89       91       +2     
  Lines        6358     6417      +59     
==========================================
+ Hits         3549     3578      +29     
- Misses       2369     2398      +29     
- Partials      440      441       +1     
Impacted Files Coverage Δ
cmd/nginx/main.go 4.23% <0.00%> (-0.07%) ⬇️
internal/ingress/controller/nginx.go 28.91% <ø> (ø)
internal/ingress/controller/status.go 0.00% <0.00%> (ø)
internal/k8s/zz_generated.deepcopy.go 0.00% <0.00%> (ø)
internal/ingress/controller/location.go 17.64% <17.64%> (ø)
...ternal/ingress/annotations/sessionaffinity/main.go 57.77% <28.57%> (ø)
internal/ingress/annotations/annotations.go 80.88% <33.33%> (ø)
internal/ingress/controller/controller.go 46.99% <33.33%> (+0.06%) ⬆️
internal/ingress/controller/store/store.go 58.94% <41.66%> (-0.11%) ⬇️
internal/ingress/controller/util.go 55.26% <50.00%> (-2.81%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a21868...edb9002. Read the comment docs.

@aledbf
Copy link
Member Author

aledbf commented Nov 17, 2020

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 17, 2020
@aledbf aledbf removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 18, 2020
@aledbf aledbf merged commit 1389cc0 into kubernetes:master Nov 19, 2020
@aledbf aledbf moved this from In Progress to done in 0.42.0 Nov 20, 2020
@aledbf aledbf deleted the cleanup branch November 20, 2020 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants