Spelling #6528

jsoref · 2020-11-27T03:23:51Z

This PR corrects misspellings identified by the check-spelling action.

The misspellings have been reported at jsoref@c3a90ca#commitcomment-44580456

What this PR does / why we need it:

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)

Which issue/s this PR fixes

How Has This Been Tested?

The action reports that the changes in this PR would make it happy: jsoref@df34f83

Note: this PR does not include the action. If you're interested in running a spell check on every PR and push, that can be offered separately.

Checklist:

My change requires a change to the documentation.
I have updated the documentation accordingly.
I've read the CONTRIBUTION guide
I have added tests to cover my changes.
All new and existing tests passed.

k8s-ci-robot · 2020-11-27T03:23:59Z

Hi @jsoref. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jsoref

The changelog includes quite a few typo fixes.

If you're interested, the action I used to develop this could be used to prevent such typos from creeping in.

jsoref · 2020-11-27T03:25:15Z

Changelog.md

@@ -212,7 +212,7 @@ _Documentation:_
 - [X] [#6180](https://github.com/kubernetes/ingress-nginx/pull/6180) Fix helm chart admissionReviewVersions regression
 - [X] [#6181](https://github.com/kubernetes/ingress-nginx/pull/6181) Improve prerequisite instructions
 - [X] [#6214](https://github.com/kubernetes/ingress-nginx/pull/6214) Update annotations.md - improvements to the documentation of Client Certificate Authentication
- [X] [#6215](https://github.com/kubernetes/ingress-nginx/pull/6215) Update the comment for Makefile taks live-docs
+- [X] [#6215](https://github.com/kubernetes/ingress-nginx/pull/6215) Update the comment for Makefile task live-docs


I intentionally avoided fixing the spelling of items in the Changelog of the form:

Fixes typo: teh -> the

I'm happy to totally ignore the changelog if requested. Personally, I prefer Changelogs that are easier to read, but I'm happy to accommodate.

docs/deploy/hardening-guide.md

docs/enhancements/YYYYMMDD-kep-template.md

docs/user-guide/cli-arguments.md

internal/ingress/annotations/secureupstream/main.go

jsoref · 2020-11-27T03:28:16Z

internal/ingress/status/status_test.go

@@ -63,7 +63,7 @@ func buildSimpleClientSet() *testclient.Clientset {
 					Name:      "foo1",
 					Namespace: apiv1.NamespaceDefault,
 					Labels: map[string]string{
-						"lable_sig": "foo_pod",
+						"label_sig": "foo_pod",


This worries me

jsoref · 2020-11-27T03:28:55Z

internal/task/queue_test.go

@@ -66,7 +66,7 @@ func TestEnqueueSuccess(t *testing.T) {
 	stopCh := make(chan struct{})
 	// run queue
 	go q.Run(5*time.Second, stopCh)
-	// mock object whichi will be enqueue
+	// mock object which will be enqueue


This probably should read enqueued but it isn't a spelling error (I'm happy to make it if requested)

rootfs/etc/nginx/lua/balancer.lua

jsoref · 2020-11-27T03:29:44Z

test/data/config.json

@@ -104,7 +104,7 @@
 				"cidr": ["1.1.1.1"]
 			},
 			"proxy": {
-				"conectTimeout": 5,
+				"connectTimeout": 5,


This worries me

aledbf · 2020-11-27T10:30:04Z

@jsoref thank you for the PR. Please don't change the Changelog.md file and squash the commits.

aledbf · 2020-11-27T17:30:52Z

/ok-to-test

jsoref · 2020-11-27T18:50:16Z

@aledbf: I don't think the failures (to the extent I can understand what's complaining) relate to my changes, are you going to be able to help me get this landed or do I need to investigate the failures in detail? (I won't have any time until next week.)

codecov-io · 2020-12-05T22:58:53Z

Codecov Report

Merging #6528 (a8728f3) into master (06f53bc) will decrease coverage by 0.05%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master    #6528      +/-   ##
==========================================
- Coverage   55.80%   55.75%   -0.06%     
==========================================
  Files          91       91              
  Lines        6433     6455      +22     
==========================================
+ Hits         3590     3599       +9     
- Misses       2401     2412      +11     
- Partials      442      444       +2

Impacted Files	Coverage Δ
cmd/nginx/main.go	`4.23% <ø> (ø)`
internal/admission/controller/convert.go	`0.00% <0.00%> (ø)`
...ternal/ingress/annotations/sessionaffinity/main.go	`57.77% <ø> (ø)`
internal/ingress/controller/location.go	`17.14% <0.00%> (-0.51%)`	⬇️
internal/ingress/controller/nginx.go	`28.86% <0.00%> (-0.05%)`	⬇️
internal/ingress/metric/collectors/process.go	`88.09% <ø> (ø)`
internal/ingress/types.go	`0.00% <ø> (ø)`
internal/ingress/controller/controller.go	`46.60% <43.58%> (-0.40%)`	⬇️
internal/net/ssl/ssl.go	`49.18% <50.00%> (+0.20%)`	⬆️
internal/ingress/controller/template/template.go	`76.62% <72.22%> (-0.24%)`	⬇️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe65e9d...a8728f3. Read the comment docs.

images/nginx/rootfs/patches/nginx-1.19.3-ssl_cert_cb_yield.patch

test/e2e/annotations/canary.go

aledbf · 2020-12-15T22:04:25Z

/lgtm
/approve

aledbf · 2020-12-15T22:04:31Z

@jsoref thanks!

k8s-ci-robot · 2020-12-15T22:04:51Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aledbf, jsoref

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [aledbf]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Nov 27, 2020

k8s-ci-robot requested review from aledbf and ElvinEfendi November 27, 2020 03:24

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 27, 2020

jsoref commented Nov 27, 2020

View reviewed changes

jsoref force-pushed the spelling branch from 733a732 to 5058804 Compare November 27, 2020 17:27

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 27, 2020

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 5, 2020

jsoref force-pushed the spelling branch from 5058804 to 8c567bd Compare December 5, 2020 22:54

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 5, 2020

jsoref commented Dec 5, 2020

View reviewed changes

images/nginx/rootfs/patches/nginx-1.19.3-ssl_cert_cb_yield.patch Outdated Show resolved Hide resolved

aledbf mentioned this pull request Dec 15, 2020

fix typos #6625

Closed

8 tasks

jsoref force-pushed the spelling branch from 8c567bd to f2340e9 Compare December 15, 2020 19:33

aledbf reviewed Dec 15, 2020

View reviewed changes

test/e2e/annotations/canary.go Outdated Show resolved Hide resolved

aledbf reviewed Dec 15, 2020

View reviewed changes

test/e2e/annotations/canary.go Outdated Show resolved Hide resolved

aledbf added this to In Progress in 0.42.0 Dec 15, 2020

Spelling

a8728f3

jsoref force-pushed the spelling branch from f2340e9 to a8728f3 Compare December 15, 2020 21:11

k8s-ci-robot assigned aledbf Dec 15, 2020

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 15, 2020

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 15, 2020

k8s-ci-robot merged commit 3a126c6 into kubernetes:master Dec 15, 2020

aledbf moved this from In Progress to done in 0.42.0 Dec 15, 2020

jsoref deleted the spelling branch December 16, 2020 12:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Spelling #6528

Spelling #6528

jsoref commented Nov 27, 2020

k8s-ci-robot commented Nov 27, 2020

jsoref left a comment

jsoref Nov 27, 2020

jsoref Nov 27, 2020

jsoref Nov 27, 2020

jsoref Nov 27, 2020

aledbf commented Nov 27, 2020 •

edited

aledbf commented Nov 27, 2020

jsoref commented Nov 27, 2020

codecov-io commented Dec 5, 2020 •

edited

aledbf commented Dec 15, 2020

aledbf commented Dec 15, 2020

k8s-ci-robot commented Dec 15, 2020

Spelling #6528

Spelling #6528

Conversation

jsoref commented Nov 27, 2020

What this PR does / why we need it:

Types of changes

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

k8s-ci-robot commented Nov 27, 2020

jsoref left a comment

Choose a reason for hiding this comment

jsoref Nov 27, 2020

Choose a reason for hiding this comment

jsoref Nov 27, 2020

Choose a reason for hiding this comment

jsoref Nov 27, 2020

Choose a reason for hiding this comment

jsoref Nov 27, 2020

Choose a reason for hiding this comment

aledbf commented Nov 27, 2020 • edited

aledbf commented Nov 27, 2020

jsoref commented Nov 27, 2020

codecov-io commented Dec 5, 2020 • edited

Codecov Report

aledbf commented Dec 15, 2020

aledbf commented Dec 15, 2020

k8s-ci-robot commented Dec 15, 2020

aledbf commented Nov 27, 2020 •

edited

codecov-io commented Dec 5, 2020 •

edited