-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding LoadBalancerIP value for internal service to Helm chart #6646
Adding LoadBalancerIP value for internal service to Helm chart #6646
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @cooperbenson-qz! |
Hi @cooperbenson-qz. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Just got my org to sign the CLA, should hopefully work now |
/ok-to-test |
Just pushed commits updating all three of those 🙂 |
Ok squash your commits down to one and then this looks good to me |
Adding documentation for the value Bumping chart version Adding changelog entry Added change to artifacthub annotation
1877e29
to
8de7d42
Compare
Pushed the squashed commit |
/assign @ChiefAlexander |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ChiefAlexander, cooperbenson-qz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The "CI / Helm chart" has been stuck for almost 30min. Can someone kill it? Otherwise, we'll need to wait 6 hours for it to timeout |
What this PR does / why we need it:
When configuring an internal service it's helpful to be able to specify the
LoadBalancerIP
value on the service.Types of changes
Which issue/s this PR fixes
N/A
How Has This Been Tested?
I ported over the same value from the main service template and made sure it renders locally with and without the value
Checklist: