Remove the force stripping of trailing slashes

[jdziat]

What this PR does / why we need it:

Someone introduced trailing slash removal as part of the force-ssl-redirect annotations. This shouldn't be default behavior.

Types of changes

• Reverted the trailing slash removal

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Welcome @jdziat!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @jdziat. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jdziat]

/assign @ElvinEfendi

[k8s-ci-robot]

@jdziat: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jdziat]

@cmluciano @ElvinEfendi Any word on whether or not we can get this back to the old behavior. This was a nasty surprise for us during an upgrade.

[jdziat]

/retest

[k8s-ci-robot]

@jdziat: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mmiller1]

this would fix #6931

[rikatz]

/ok-to-test
/assign

Hey @jdziat can you please track which commit inserted this behavior? I want to see what was the discussion about that.

Thanks!

[jdziat]

/ok-to-test
/assign

Hey @jdziat can you please track which commit inserted this behavior? I want to see what was the discussion about that.

Thanks!

The commit originated to comply with the ingress specification for k8s. It just happened to break a lot of things in our deployments.

Commit ID: 493dd67

[rikatz]

/cc

[mmiller1]

Is there anything that can be done to help move this forward?

[tao12345666333]

/lgtm
/retest

[jdziat]

@tao12345666333 We can't move forward with this PR the way it is. On further research the reason it was implemented is valid. The ingress working group does not agree with trailing slashes. So I think the best way to proceed is to put this behind an annotation toggle or similar enhancement.

[tao12345666333]

got it. @jdziat

/lgtm cancel

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jdziat
To complete the pull request process, please ask for approval from elvinefendi after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mmiller1]

I opened #7144 to implement this via an optional annotation.

[jdziat]

@mmiller1 Looks good, going to close this out.