Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update base nginx image to the corrected version #7705

Merged
merged 1 commit into from Sep 26, 2021
Merged

Update base nginx image to the corrected version #7705

merged 1 commit into from Sep 26, 2021

Conversation

rikatz
Copy link
Contributor

@rikatz rikatz commented Sep 26, 2021

As soon as kubernetes/k8s.io#2822 gets merged, this can be re-tested and if everything works fine, merged too.

Also this should be cherry picked to legacy branch

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 26, 2021
@k8s-ci-robot
Copy link
Contributor

@rikatz: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority labels Sep 26, 2021
@rikatz
Copy link
Contributor Author

rikatz commented Sep 26, 2021

/hold
Wait until kubernetes/k8s.io#2822 gets merged

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 26, 2021
@rikatz
Copy link
Contributor Author

rikatz commented Sep 26, 2021

/cc @tao12345666333 @strongjz
/assign @tao12345666333 @strongjz

tao12345666333
tao12345666333 approved these changes Sep 26, 2021
View reviewed changes
Copy link
Member

@tao12345666333 tao12345666333 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Sep 26, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rikatz, tao12345666333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@rikatz
Copy link
Contributor Author

rikatz commented Sep 26, 2021

/hold

Let's wait the CI :)

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 26, 2021
@tao12345666333
Copy link
Member

OK

@rikatz
Copy link
Contributor Author

rikatz commented Sep 26, 2021

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 26, 2021
@k8s-ci-robot k8s-ci-robot merged commit 6885ab2 into kubernetes:main Sep 26, 2021
rikatz added a commit to rikatz/ingress-nginx that referenced this pull request Sep 26, 2021
@rikatz
Update base nginx image to the corrected version (kubernetes#7705)
07c962f
@rikatz rikatz mentioned this pull request Sep 26, 2021
Merged
k8s-ci-robot pushed a commit that referenced this pull request Sep 27, 2021
@rikatz
Update base nginx image and tag new release (#7706)
d5f3499 
* Update base nginx image to the corrected version (#7705)

* Tag release v0.49.2
rchshld pushed a commit to joomcode/ingress-nginx that referenced this pull request May 19, 2023
@rikatz @rchshld
Update base nginx image to the corrected version (kubernetes#7705)
658d29a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tao12345666333 tao12345666333 tao12345666333 approved these changes

@strongjz strongjz Awaiting requested review from strongjz

Assignees

@strongjz strongjz

@tao12345666333 tao12345666333

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rikatz @k8s-ci-robot @tao12345666333 @strongjz