New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CI for images/kube-webhook-certgen #7717
Add CI for images/kube-webhook-certgen #7717
Conversation
As a follow up to PR kubernetes#7641, this commit adds some basic e2e tests for kube-webhook-certgen image. Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
@invidian: This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @invidian. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
cd images/kube-webhook-certgen && make build | ||
|
||
test-image: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit here: test-image-what? Would be good to explain we are testing image-webhook.
Approving and lgtming here anyway, I will put a hold if you think this deserves to be fixed, otherwise just remove the hold !
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, the section above is named test-image-build
, maybe this should be named image-test
then? To indicate that we run tests for images?
I assume test-image-build
was previously used only for building test image and then evolved into building other images as well, without being renamed?
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: invidian, rikatz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@invidian we can release the new one split from the rest of the process :) Is just a matter of merging and promoting the image. Ping me on slack, can show you how to do that! |
As a follow up to PR kubernetes#7641, this commit adds some basic e2e tests for kube-webhook-certgen image. Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
What this PR does / why we need it:
As a follow up to PR #7641, this commit adds some basic e2e tests for
kube-webhook-certgen image.
Signed-off-by: Mateusz Gozdek mgozdek@microsoft.com
Types of changes
Which issue/s this PR fixes
How Has This Been Tested?
Locally.
Checklist: