Fix api version, in basic usage docs, for example ingress objects, for K8s version <1.19

[tacf]

Oficial documentation sources:

https://kubernetes.io/blog/2019/07/18/api-deprecations-in-1-16/
https://kubernetes.io/docs/reference/using-api/deprecation-guide/#ingress-v122

What this PR does / why we need it:

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation only

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have added tests to cover my changes.
• All new and existing tests passed.

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[linux-foundation-easycla]

The committers are authorized under a signed CLA.

• ✅ Tiago Ferreira (8a7e16b)

[k8s-ci-robot]

@tacf: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Welcome @tacf!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @tacf. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[longwuyuan]

The main branch will reflect support for latest release of K8S so thi PR is invalid.

If you have opinions/thoughts that are not expressed here,, Please create a issue and detail why the main documentation should spec deprecated apiVersion. THen link it here. If it makes sense then this PR can be re-opened.

/close

[k8s-ci-robot]

@longwuyuan: Closed this PR.

In response to this:

The main branch will reflect support for latest release of K8S so thi PR is invalid.

If you have opinions/thoughts that are not expressed here,, Please create a issue and detail why the main documentation should spec deprecated apiVersion. If it makes sense then this PR can be re-opened.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[tacf]

Reopening PR as requested by @longwuyuan

/reopen

[k8s-ci-robot]

@tacf: Reopened this PR.

In response to this:

Reopening PR as requested by @longwuyuan

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[longwuyuan]

@tacf, thanks again for the PR.
(1) Please fix the fields of the example ingress as well.
(2) Please squash your commits.

[longwuyuan]

hi @tacf in case you have not noticed, you need to change other fields in the example.
Please refer to this tacf@20b6202#diff-2557e273e2e853519de46160cf6c79f45c3f46d8e8a8f97cc8c32f613c99a7da

[longwuyuan]

You don't see this screenshot attached

Sugested you change this

f cluster version >= 1.19 the Ingress resource above will not work, instead of annotations you should use the new `ingressClassName: nginx` property.

to this

if the cluster is created using Kubernetes version >= 1.19.x, then its suggested to create 2 ingress resources, using yaml examples shown below. These examples are confirming to networking.kubernetes.io/v1 api ;

[tacf]

While you review is pending i'll not be able to see it. You need to publish it first. Changed the text based on your suggestion with minor wording differences.

[longwuyuan]

I am still unsure where I messed up but i was able to cancel that pending thing, as the file has changed already, based on your latest commit. We can move ahead for now.

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: longwuyuan, tacf

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• docs/OWNERS [longwuyuan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[longwuyuan]

/kind documentation

[longwuyuan]

/retest

[longwuyuan]

Hi @tacf , your PR has merged but I don't see the docs website content change at https://kubernetes.github.io/ingress-nginx/user-guide/basic-usage/ .

Can you confirm that you too, don't see the content changed ?

[tacf]

Hi, can't see it yet. It seems that there was no new release after the changes so i'm guessing that's the reason why.

[tacf]

As a note, this resolves #8122

[longwuyuan]

I am waiting to find out why the docs website does not reflect the change. So I can make the website look good as well.
This resolved 8122 in part as in looking at the md file in github code browser is good but the website which uses that file is not.

[longwuyuan]

https://github.com/kubernetes/ingress-nginx/runs/4794122708?check_suite_focus=true

[tacf]

Seems to be a deeper problem with the actions configured or some previous issue. Actions for documentation publishing are failing for a while now. Do you have any ideia who to escalate this to?

[longwuyuan]

Escalated already. Lets wait for updates. Glad we know more now. Thanks, ; Long Wu Yuan

…

On 1/13/22 7:21 PM, Tiago Ferreira wrote: Seems to be a deeper problem with the actions configured or some previous issue. Actions for documentation publishing are failing for a while now. Do you have any ideia who to escalate this to? — Reply to this email directly, view it on GitHub <#8112 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABGZVWVAIRWUS2MAKTNV6YLUV3KG5ANCNFSM5LO5NDUQ>. Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were assigned.Message ID: ***@***.***>

[longwuyuan]

@tacf, i see that a documentation job and a helm job passed in the gh-actions pipeline.
The previous fail on the deploy job for your PR does not show obvious error message.

Can you submit one more PR with the exact same content and just add/remove a space or a dot/period character so that there is at least a one char diff. I will approve it so it can fire another CI run and hopefully make progress on updating tthat doc website page.

[tacf]

Did you check if the job executed the update phase? There are many docs workflows that pass but those are mainly the one that do not go into de update stage. I've checked a few and they all fail when executing the update stage

[longwuyuan]

That is correct. The "apparent" pass is because of update steps not running and we are suspecting expired token. Only way to know more is run the job so I asked for another PR. Thanks, ; Long Wu Yuan

…

On 1/14/22 3:05 PM, Tiago Ferreira wrote: Did you check if the job executed the update phase? There are many docs workflows that pass but those are mainly the one that do not go into de update stage. I've checked a few and they all fail when executing the update stage — Reply to this email directly, view it on GitHub <#8112 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABGZVWRQCZDIAGT4SVXFBZDUV7U7VANCNFSM5LO5NDUQ>. Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were assigned.Message ID: ***@***.***>

[tacf]

@longwuyuan sorry i missed this last message of yours. The same content on another PR will probably not work because the update only runs on master and with content changes on docs. So actually we need another "real" change, or if possible to re-run some previous workflow.

[longwuyuan]

We fixed the token and website is updated after a cosmetic-change PR. Can you check and confirm ? Thanks, ; Long Wu Yuan

…

On 1/17/22 7:24 PM, Tiago Ferreira wrote: @longwuyuan <https://github.com/longwuyuan> sorry i missed this last message of yours. The same content on another PR will probably not work because the update only runs on master and with content changes on docs. So actually we need another "real" change, or if possible to re-run some previous workflow. — Reply to this email directly, view it on GitHub <#8112 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABGZVWSW3MVQYAEW2VC7KA3UWQNQ5ANCNFSM5LO5NDUQ>. Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[tacf]

@longwuyuan yes, change is there. Tyvm for all the help

[longwuyuan]

Thank you very much for your contribution. Helps a lot.