prometheus+grafana using servicemonitor

[indhupriya]

Documentation for configuring Prometheus and Grafana using service monitors

What this PR does / why we need it:

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation only

Which issue/s this PR fixes

#8170

How Has This Been Tested?

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have added tests to cover my changes.
• All new and existing tests passed.

[linux-foundation-easycla]

• ❌ The commit (9b135a1) is missing the User's ID, preventing the EasyCLA check. Consult GitHub Help to resolve.For further assistance with EasyCLA, please submit a support request ticket.

[k8s-ci-robot]

Welcome @indhupriya!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @indhupriya. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[linux-foundation-easycla]

• ❌ The commit (9b135a1) is missing the User's ID, preventing the EasyCLA check. Consult GitHub Help to resolve.For further assistance with EasyCLA, please submit a support request ticket.

[iamNoah1]

Nice Job @indhupriya, please sign the CLA.
/lgtm in general, but would like to have a second opinion
/hold for @longwuyuan, @tao12345666333, @strongjz or @rikatz

/triage accepted
/kind documentation
/priority important-soon

[iamNoah1]

/approve cancel, until change requests are implemented.

[iamNoah1]

/approve cancel

[linux-foundation-easycla]

• ✅ Indhu Kumar (b372f86)

• ❌ The commit (9b135a1) is missing the User's ID, preventing the EasyCLA check. Consult GitHub Help to resolve.For further assistance with EasyCLA, please submit a support request ticket.

[longwuyuan]

Please check markdown

[longwuyuan]

If you can put a simple workload and run some traffic, it will help populate the dashboard. If success, then look forward to completing else need to fix whatever is broken. Thanks, ; Long

…

On 2/3/22 9:50 PM, Noah Ispas wrote: ***@***.**** commented on this pull request. ------------------------------------------------------------------------ In docs/user-guide/monitoring.md <#8186 (comment)>: > @@ -1,11 +1,15 @@ # Prometheus and Grafana installation +Two different methods to install and configure Prometheus and Grafana are described in this doc. +- Prometheus and Grafana installation using Pod Annotations. This installs Prometheus and Grafana in the same namespace as NGINX Ingress +- Prometheus and Grafana installation using Service Monitors. This is more suited for existing Prometheus and Grafana installations that can be configured with NGINX Ingress for scraping the metrics. ok, so back to the question if the PR is finished for now or if you want to implement the suggestions from @villesau <https://github.com/villesau> — Reply to this email directly, view it on GitHub <#8186 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABGZVWW7J2LWXKZKY54JQMTUZKTMBANCNFSM5MZ56EAA>. Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.***>

[indhupriya]

I made more changes to implement suggestions from @villesau and @longwuyuan I have also repopulated Grafana charts. Please review.

[longwuyuan]

@indhupriya this looks good and is extremely helpful.
Just a nit. Please verify if this sentenace ;

By default, Prometheus only discovers PodMonitors 

should actually say "servicemonitors" or not, instead of podmonitors.

PS - Kindly click the button to resolve earlier review comments

[indhupriya]

@indhupriya this looks good and is extremely helpful. Just a nit. Please verify if this sentenace ;

By default, Prometheus only discovers PodMonitors 

should actually say "servicemonitors" or not, instead of podmonitors.

PS - Kindly click the button to resolve earlier review comments

Actually we set both podMonitorSelectorNilUsesHelmValues and serviceMonitorSelectorNilUsesHelmValues flags to false. There is explanation for both.

[iamNoah1]

/lgtm
/hold cancel

thanks @indhupriya @longwuyuan

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamNoah1, indhupriya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• docs/OWNERS [iamNoah1]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[villesau]

Great work @indhupriya, I wish I had these instructions when setting up prometheus for nginx :) Would have saved a ton of time.

[longwuyuan]

+1 this is awesome help Thanks, ; Long

…

On Mon, 7 Feb, 2022, 4:07 PM Ville Saukkonen, ***@***.***> wrote: Great work @indhupriya <https://github.com/indhupriya>, I wish I had these instructions when setting up prometheus for nginx :) Would have saved a ton of time. — Reply to this email directly, view it on GitHub <#8186 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABGZVWU6QQSL4E3K57YJ2OLUZ6OFFANCNFSM5MZ56EAA> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>. You are receiving this because you were mentioned.Message ID: ***@***.***>