use functional options to reduce number of methods creating an EchoDeployment

[dmathieu]

What this PR does / why we need it:

This PR is a refactoring of the NewEchoDeployment test helper. We currently require several methods which are becoming quite long in their name, this so we can specify some arguments or others.
The refactor relies on functional attributes instead to allow specifying only the attributes we need while retaining only one method.

Before:

f.NewEchoDeploymentWithNamespaceAndReplicas("namespace", 2)

After:

f.NewEchoDeployment(
  framework.WithDeploymentNamespace("namespace"),
  framework.WithDeploymentReplicas(2),
)

I need this as part of my sidecar modules work. With this change in place, I will be able to add a WithDeploymentModules option which will allow configuring modules for a deployment.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation only

This is a refactoring of test helpers.

How Has This Been Tested?

This is being fully tested through unit and e2e tests.

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have added tests to cover my changes.
• All new and existing tests passed.

[k8s-ci-robot]

Hi @dmathieu. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[strongjz]

/kind feature
/priority backlog
/triage accepted
/ok-to-test

Thanks for simplifying those tests.

[rikatz]

This is a great change! Thanks!
/approve
/hold

[iamNoah1]

@rikatz why are we holding?

/cancel hold

[iamNoah1]

/hold cancel

[iamNoah1]

/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dmathieu, iamNoah1, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [rikatz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment