Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(metrics): add path and method labels to requests counter #8201

Merged
merged 1 commit into from
Jan 30, 2022
Merged

feat(metrics): add path and method labels to requests counter #8201

merged 1 commit into from
Jan 30, 2022

Conversation

naseemkullah
Copy link
Contributor

What this PR does / why we need it:

closes #8200

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation only

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Metrics are not yet documented:

  • I've read the CONTRIBUTION guide
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 27, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @naseemkullah. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 27, 2022
@naseemkullah naseemkullah force-pushed the path-method-labels-requests-counter branch from 2b5d7ac to cd95c41 Compare January 27, 2022 16:07
kd7lxl
kd7lxl reviewed Jan 27, 2022
View reviewed changes
internal/ingress/metric/collectors/socket.go
@@ -190,7 +190,7 @@ func NewSocketCollector(pod, namespace, class string, metricsPerHost bool, bucke
Namespace: PrometheusNamespace,
ConstLabels: constLabels,
},
[]string{"ingress", "namespace", "status", "service", "canary"},
requestTags,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow, I can't believe we had method and path for histograms all along if the concern was cardinality. Histograms are much more sensitive to cardinality since they have multiple metrics * buckets.

It makes sense to add method and path to nginx_ingress_controller_requests, since these are valuable and each have finite cardinality. LGTM.

@naseemkullah naseemkullah marked this pull request as ready for review January 27, 2022 16:33
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jan 27, 2022
@naseemkullah
Copy link
Contributor Author

/assign @ElvinEfendi

@naseemkullah
Copy link
Contributor Author

/assign @tao12345666333

@naseemkullah
Copy link
Contributor Author

/assign @strongjz @rikatz

@strongjz
Copy link
Member

/ok-to-test
/triage accepted
/priority backlog

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 28, 2022
iamNoah1
iamNoah1 reviewed Jan 29, 2022
View reviewed changes
Copy link
Contributor

@iamNoah1 iamNoah1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/kind feature
/lgtm

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jan 29, 2022
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 29, 2022
@rikatz
Copy link
Contributor

rikatz commented Jan 30, 2022

/approve
Thanks

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: iamNoah1, naseemkullah, rikatz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2022
@k8s-ci-robot k8s-ci-robot merged commit fbdfc65 into kubernetes:main Jan 30, 2022
@naseemkullah naseemkullah deleted the path-method-labels-requests-counter branch January 30, 2022 17:31
This was referenced Feb 5, 2022
Closed
Merged
@tao12345666333 tao12345666333 mentioned this pull request Feb 27, 2022
Closed
@ekovacs ekovacs mentioned this pull request Jul 5, 2022
Closed
rchshld pushed a commit to joomcode/ingress-nginx that referenced this pull request May 19, 2023
@naseemkullah @rchshld
feat(metrics): add path and method labels to requests counter (kubern…
521507c 
…etes#8201)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kd7lxl kd7lxl kd7lxl left review comments

@iamNoah1 iamNoah1 iamNoah1 left review comments

@ElvinEfendi ElvinEfendi Awaiting requested review from ElvinEfendi

@strongjz strongjz Awaiting requested review from strongjz

@rikatz rikatz Awaiting requested review from rikatz

@tao12345666333 tao12345666333 Awaiting requested review from tao12345666333

Assignees

@ElvinEfendi ElvinEfendi

@strongjz strongjz

@tao12345666333 tao12345666333

@rikatz rikatz

@iamNoah1 iamNoah1

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

prometheus metrics: add path label to nginx_ingress_controller_requests
8 participants
@naseemkullah @k8s-ci-robot @strongjz @rikatz @kd7lxl @iamNoah1 @ElvinEfendi @tao12345666333