-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add patch to remove root and alias directives #8624
Add patch to remove root and alias directives #8624
Conversation
@rikatz: This issue is currently awaiting triage. If Ingress contributors determines this is a relevant issue, they will accept it by applying the The Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rikatz, tao12345666333 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hey @rikatz, With best regards |
Can you point me (in Slack) how you've been doing it? Iirc custom errors has its own directives @longwuyuan may know |
@nhinze23 , thanks for your update. As @rikatz said, I too feel it will help a lot to see precise details of your extensions. As suggested, you could copy/paste start a thread at https://kubernetes.slack.com in the ingress-nginx-dev channel. Thank you |
Trying to follow the Nginx guide for service static assets and getting this error when trying to set the root: `------------------------------------------------------------------------------- -------------------------------------------------------------------------------`
Can anyone point me in the right direction to add that root as suggested by Nginx? Many thanks. |
We don't support root directive on ingress-nginx :) you are not supposed to serve static files from there. Instead you should create a backend containing it, and do ingress point to that backend |
Adds a patch to remove root and alias directives.
This directives are not required by Ingress and has been used to explore some reading of sensitive files