Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 1.4.0 #9108

Merged
merged 1 commit into from
Oct 2, 2022
Merged

Release 1.4.0 #9108

merged 1 commit into from
Oct 2, 2022

Conversation

strongjz
Copy link
Member

What this PR does / why we need it:

Release 1.4.0

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • CVE Report (Scanner found CVE and adding report)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation only
none

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Sep 30, 2022
@k8s-ci-robot
Copy link
Contributor

@strongjz: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Sep 30, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: strongjz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added area/helm Issues or PRs related to helm charts approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Sep 30, 2022
rikatz
rikatz reviewed Sep 30, 2022
View reviewed changes
README.md Outdated Show resolved Hide resolved
@strongjz strongjz force-pushed the release-1.4.0 branch 3 times, most recently from 666ec85 to 41b6d8b Compare September 30, 2022 20:13
@strongjz strongjz requested review from rikatz and removed request for ChiefAlexander September 30, 2022 22:54
@longwuyuan
Copy link
Contributor

@strongjz Dropping support for K8S v1.20.X is only mentioned in the support matrix and the chart readme but in my opinion it should also be a highlighted in the app changelog, like the other important changes highlighted there.

@tao12345666333 tao12345666333 mentioned this pull request Oct 2, 2022
Merged
9 tasks
@strongjz
update for 1.4.0 release
c4a50eb 
Signed-off-by: James Strong <strong.james.e@gmail.com>
@strongjz strongjz merged commit cc79e14 into kubernetes:main Oct 2, 2022
@strongjz strongjz deleted the release-1.4.0 branch October 2, 2022 23:41
yutachaos
yutachaos reviewed Oct 3, 2022
View reviewed changes
Changelog.md
[8890](https://github.com/kubernetes/ingress-nginx/pull/8890)
* Update to Prometheus metric names, more information [available here]( https://github.com/kubernetes/ingress-nginx/pull/8728
)
* Deprecated Kubernetes versions 1.20-1.21, Added support for, 1.25, currently supported versions v1.23, v1.24, v1.25
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

k8s 1.22 is gone, is 1.22 a still supported version?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is still supported through October, we are following the kubernetes supported versions. I added it back into the CI for testing.

@yutachaos yutachaos mentioned this pull request Oct 3, 2022
Merged
11 tasks
@hairmare hairmare mentioned this pull request Nov 22, 2022
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yutachaos yutachaos yutachaos left review comments

@tao12345666333 tao12345666333 Awaiting requested review from tao12345666333

@longwuyuan longwuyuan Awaiting requested review from longwuyuan

@ElvinEfendi ElvinEfendi Awaiting requested review from ElvinEfendi

@rikatz rikatz Awaiting requested review from rikatz

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/docs area/helm Issues or PRs related to helm charts cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@strongjz @k8s-ci-robot @longwuyuan @rikatz @yutachaos