Add geoname id value into $geoip2_*_geoname_id variables

[Rakoth]

What this PR does / why we need it:

This PR adds geoip2 variables

• $geoip2_city_geoname_id,
• $geoip2_subregion_geoname_id
• $geoip2_region_geoname_id
• $geoip2_city_country_geoname_id
• $geoip2_country_geoname_id
• $geoip2_continent_geoname_id

with geoname ids information according to a source ip. Applications may get this value from nginx controller directly instead of using another geoip2 request.

How Has This Been Tested?

Tested locally

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• CVE Report (Scanner found CVE and adding report)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation only

Checklist:

• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I've read the CONTRIBUTION guide
• I have added unit and/or e2e tests to cover my changes.
• All new and existing tests passed.
• Added Release Notes.

Adding geoname ids geoip variables

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: Rakoth / name: Alexander Stanko (e9d5e0a)

[k8s-ci-robot]

@Rakoth: This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Hi @Rakoth. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

Welcome @Rakoth!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[Rakoth]

Hello @rikatz! Any chance you can review this small change soon?

[foxdalas]

@aledbf Hi! Maybe you can help with review?

[tao12345666333]

/assign

I will add this to my list.

[tao12345666333]

/ok-to-test

[tao12345666333]

Can you provide steps to reproduce? I need to make sure it doesn't have other effects.

[Rakoth]

Can you provide steps to reproduce? I need to make sure it doesn't have other effects.

Hello @tao12345666333 ! Thanks for your response!

We start ingress controller with following arguments

    --configmap=ingress/ingress-nginx-controller
    --maxmind-mirror=http://some.mirror.geoip.io
    --maxmind-edition-ids=GeoIP2-City,GeoIP2-Country,GeoIP2-ISP

and ingress/ingress-nginx-controller config map has proxy-set-headers option, which points to another config map ingress/custom-headers:

data:
  X-GeoIP2-City-Geoname-ID: $geoip2_city_geoname_id
  X-GeoIP2-Subregion-Geoname-ID: $geoip2_subregion_geoname_id
  X-GeoIP2-Region-Geoname-ID: $geoip2_region_geoname_id
  X-GeoIP2-City-Country-Geoname-ID: $geoip2_city_country_geoname_id
  X-GeoIP2-Country-Geoname-ID: $geoip2_country_geoname_id
  X-GeoIP2-Continent-Geoname-ID: $geoip2_continent_geoname_id
  X-GeoIP2-City: $geoip2_city
  X-GeoIP2-Country-Code: $geoip2_city_country_code
  X-GeoIP2-DMA-Code: $geoip2_dma_code
  X-GeoIP2-ISP: $geoip2_isp
  X-GeoIP2-Latitude: $normalize_geoip2_latitude
  X-GeoIP2-Longitude: $normalize_geoip2_longitude
  X-GeoIP2-Postal-Code: $geoip2_postal_code
  X-GeoIP2-Region-Code: $geoip2_region_code
  X-GeoIP2-Region-Name: $geoip2_region_name
  X-GeoIP2-Time-Zone: $geoip2_time_zone

And the final step is our application, which reads this request headers

[Rakoth]

@tao12345666333 Hi! Is there any actions needed from my side to proceed forward with this PR?

[Rakoth]

@tao12345666333 Could you help with this PR please?

[tao12345666333]

Sorry for the long delay.
I don't think this modification will cause any additional issues.

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Rakoth, tao12345666333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [tao12345666333]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment