Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update httpbin to httpbun #9919

Merged
merged 1 commit into from
May 10, 2023
Merged

Conversation

Spazzy757
Copy link
Contributor

@Spazzy757 Spazzy757 commented May 3, 2023

What this PR does / why we need it:

This PR is moving from HTTPBin to HTTPBun in order to fix flaky E2E tests.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • CVE Report (Scanner found CVE and adding report)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation only

Which issue/s this PR fixes

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added unit and/or e2e tests to cover my changes.
  • All new and existing tests passed.
  • Added Release Notes.

Does my pull request need a release note?

Any user-visible or operator-visible change qualifies for a release note. This could be a:

  • CLI change
  • API change
  • UI change
  • configuration schema change
  • behavioral change
  • change in non-functional attributes such as efficiency or availability, availability of a new platform
  • a warning about a deprecation
  • fix of a previous Known Issue
  • fix of a vulnerability (CVE)

No release notes are required for changes to the following:

  • Tests
  • Build infrastructure
  • Fixes for unreleased bugs

For more tips on writing good release notes, check out the Release Notes Handbook

NONE

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 3, 2023
@Spazzy757 Spazzy757 marked this pull request as draft May 3, 2023 07:24
@k8s-ci-robot k8s-ci-robot added needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. labels May 3, 2023
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If Ingress contributors determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

Welcome @Spazzy757!

It looks like this is your first PR to kubernetes/ingress-nginx 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/ingress-nginx has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @Spazzy757. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 3, 2023
@Spazzy757 Spazzy757 force-pushed the main branch 4 times, most recently from 9d985cf to a713b41 Compare May 3, 2023 15:41
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 3, 2023
@longwuyuan
Copy link
Contributor

@Spazzy757 curious why the LANG and LC vars need to be removed from Dockerfile

@Spazzy757
Copy link
Contributor Author

@Spazzy757 curious why the LANG and LC vars need to be removed from Dockerfile

@longwuyuan honestly haven't finished it yet, just getting it working first then will clean it all up 😅

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 4, 2023
@Spazzy757 Spazzy757 force-pushed the main branch 2 times, most recently from 8f1426b to ba5ab71 Compare May 4, 2023 11:56
@Spazzy757 Spazzy757 marked this pull request as ready for review May 4, 2023 11:56
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 4, 2023
@k8s-ci-robot k8s-ci-robot requested a review from rikatz May 4, 2023 11:56
assert.Nil(ginkgo.GinkgoT(), err)

httpbinIP = e.Subsets[0].Addresses[0].IP
httpbunIP = e.Subsets[0].Addresses[0].IP
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

follow up for another PR: this repeats a lot. Maybe we should define httpBun as a real part of framework, and add this as a method or part of the "f" structure

Spec: corev1.ServiceSpec{
Ports: []corev1.ServicePort{
{
Name: "http",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cant remember, so asking: do we have TLS tests pointing to httpbin or echo? do we want to move those to httpbun as well?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the backend matter?

If we can get rid of an image and move everything echo does to httpbun, I'm all for it. Another follow-up issue.

test/e2e/settings/brotli.go Outdated Show resolved Hide resolved
Signed-off-by: Spazzy <brendankamp757@gmail.com>
@Spazzy757
Copy link
Contributor Author

@strongjz @rikatz Let me know what you think so far. I just am having issues moving the request smuggling test over for now as there seems to be some kind of network error. But not sure how important it is to get the E2E tests in

@rikatz
Copy link
Contributor

rikatz commented May 10, 2023

/approve

This is a very welcome migration. Just make sure we are using that internal httpbun image as much as possible here, and we are good to go.

/hold
@strongjz and @tao12345666333 have the lgtm

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels May 10, 2023
@strongjz
Copy link
Member

/lgtm
/unhold

Thanks for this @Spazzy757. This is a huge improvement to our e2e framework, removing unsupported images like httpbin.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 10, 2023
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rikatz, Spazzy757, strongjz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@longwuyuan
Copy link
Contributor

@Spazzy757 , like this a lot. Looking forward to the framework PR

@k8s-ci-robot k8s-ci-robot merged commit 0bdb643 into kubernetes:main May 10, 2023
36 checks passed
@rikatz rikatz mentioned this pull request Jun 5, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants