Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump pinned ginkgo to v2.9.5 #9985

Merged
merged 1 commit into from
May 22, 2023

Conversation

longwuyuan
Copy link
Contributor

@longwuyuan longwuyuan commented May 22, 2023

What this PR does / why we need it:

  • There are 4 places in the code where ginkgo version is pinned
  • Dependabot bumped ginkgo from v2.9.0 to v2.9.5 in Bump github.com/onsi/ginkgo/v2 from 2.9.0 to 2.9.5 #9980
  • Dependabot can/does not change the pinned version of ginkgo
  • This PR is yet another one in a series of PRs that bumps pinned ginkgo version, whenever dependabot bumps ginkgo
  • This PR will re-generate the test-runner docker image so follow up PRs should/will be created to promote the new test-runner image to prod registry, in addition to updating project code to use the newly promoted test-runner image tag and sha

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • CVE Report (Scanner found CVE and adding report)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation only

Which issue/s this PR fixes

  • No issue was created as this is a follow up version upgrade

How Has This Been Tested?

  • Can be tested in CI only after merging this and promoting the resulting new test-runner image

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have added unit and/or e2e tests to cover my changes.
  • All new and existing tests passed.

/triage accepted
/priority important-soon
/kind bug

cc @rikatz @cpanato @strongjz @tao12345666333 seeking review/lgtm/approve. thanks

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 22, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label May 22, 2023
@longwuyuan longwuyuan changed the title bumped ginkgo to v2.9.5 bump ginkgo to v2.9.5 May 22, 2023
@longwuyuan longwuyuan changed the title bump ginkgo to v2.9.5 bump pinned ginkgo to v2.9.5 May 22, 2023
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 22, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, longwuyuan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 22, 2023
@k8s-ci-robot k8s-ci-robot merged commit 5bc7dc8 into kubernetes:main May 22, 2023
26 checks passed
@longwuyuan longwuyuan deleted the bump-to-ginkgo295 branch May 23, 2023 01:00
@longwuyuan longwuyuan mentioned this pull request May 23, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants