Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated the OWNERS file to reflect ownership of k/klog #222

Closed
neolit123 opened this issue Mar 9, 2021 · 9 comments
Closed

updated the OWNERS file to reflect ownership of k/klog #222

neolit123 opened this issue Mar 9, 2021 · 9 comments
Assignees
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@neolit123
Copy link
Member

neolit123 commented Mar 9, 2021

Describe the solution you'd like

when k/klog was originally created (as a fork of glog) the project was owned by SIG Arch, but later it was stated that this should be owned by SIG Instrumentation. klog is listed as a sub-project SIG instrumentation:
https://github.com/kubernetes/community/tree/master/sig-instrumentation#klog

but the OWNER file in this repository does not reflect the owning SIG and contains a list of volunteers, who are mostly inactive here:
https://github.com/kubernetes/klog/blob/master/OWNERS

it feels like it should be updated with SIG Instrumentation members that can monitory changes closely, especially such that are breaking.

/assign @dims @ehashman
/kind cleanup
@kubernetes/sig-instrumentation-members

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Mar 9, 2021
@neolit123
Copy link
Member Author

/priority important-longterm

@k8s-ci-robot k8s-ci-robot added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Mar 9, 2021
@ehashman
Copy link
Member

We recently reviewed this as part of the SIG Instrumentation annual report. We noted subproject owners as @dims @thockin and @DirectXMan12 and we added @dims to the SIG Instrumentation roster.

We have an agenda item this week to discuss forming a logging WG. Perhaps we can discuss this further then. https://docs.google.com/document/d/1FE4AQ8B49fYbKhfg4Tx0cui1V0eI4o3PxoqQPUwNEiU/edit#heading=h.cx8m0c4qz1jr

@neolit123
Copy link
Member Author

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Apr 27, 2021
@dims
Copy link
Member

dims commented Jan 31, 2022

@ehashman given what's in OWNERS now https://github.com/kubernetes/klog/blob/main/OWNERS what do you want to do here? i am happy to close it.

@dims dims removed their assignment Jan 31, 2022
@pohly
Copy link

pohly commented Feb 15, 2022

Are we sure everyone listed in OWNERS is still active and will respond to review resp. approve requests?

@ehashman
Copy link
Member

@dims given who's in the OWNERS file now, many of whom have gone emeritus, we think this is still relevant. @serathius will run your maintainers script to update the list.

@serathius
Copy link

Done #309

@ehashman
Copy link
Member

/close

@k8s-ci-robot
Copy link

@ehashman: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Development

No branches or pull requests

6 participants