Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide example how to use dep override for glog proxy #24

Closed
dmage opened this issue Nov 27, 2018 · 1 comment · Fixed by #36
Closed

Provide example how to use dep override for glog proxy #24

dmage opened this issue Nov 27, 2018 · 1 comment · Fixed by #36
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@dmage
Copy link

dmage commented Nov 27, 2018

/kind feature

I tried to add to my Godep.toml next lines

[[override]]
    name = "github.com/golang/glog"
    source = "k8s.io/klog/glog"

but apparently dep ignored the /glog suffix and copied entire klog into vendor/github.com/golang/glog. And it looks dep's authors don't want to have subdirs.

As dep is mentioned in the README file, I expect there should be a way to do it, though.

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Nov 27, 2018
@dims
Copy link
Member

dims commented Jan 25, 2019

@dmage as you said, it does not work, so removing it in #36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants