test: cleanup temporary file #205
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
Welcome @zhijianli88! |
k8s-ci-robot
added
the
size/XS
klog_test.go
Outdated
| @@ -567,6 +567,7 @@ func TestOpenAppendOnStart(t *testing.T) { | |||
| if !strings.Contains(string(b), x) { | |||
| t.Fatalf("got %s, missing expected Info log: %s", string(b), x) | |||
| } | |||
| os.Remove(f.Name()) | |||
There was a problem hiding this comment.
can this be:
defer os.Remove..
after this:
f, err := ioutil.TempFile("", "test_klog_OpenAppendOnStart")
if err != nil {
..
}
// < --- add here
?
There was a problem hiding this comment.
My initial thought was as your suggestion, but i guess it would be better that we can get some hints from this temproary log file when test failed
There was a problem hiding this comment.
it's better to always remove it, otherwise the test is leaking files on disk.
if the test is failing the developer can comment the line to debug.
k8s-ci-robot
added
triage/accepted
Signed-off-by: Li Zhijian <lizhijian@cn.fujitsu.com>
k8s-ci-robot
added
the
lgtm
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, neolit123, zhijianli88 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Signed-off-by: Li Zhijian lizhijian@cn.fujitsu.com
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: