Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating Routes for Services #140

Closed
kadel opened this issue Sep 2, 2016 · 9 comments
Closed

Creating Routes for Services #140

kadel opened this issue Sep 2, 2016 · 9 comments
Labels
component/OpenShift kind/feature Categorizes issue or PR as related to a new feature.

Comments

@kadel
Copy link
Member

kadel commented Sep 2, 2016

OpenShift can expose Services using Routes.

It would be nice if Kompose created default Routes for some services.

User can specify for which services Route should be created for example like this:

kompose convert --expose-service=<service name>

cc: @kbsingh

@kadel kadel added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 2, 2016
@sebgoa
Copy link
Contributor

sebgoa commented Sep 5, 2016

@kadel sounds good. Only issue will be how to handle this for multiple providers.

i.e for vanilla Kubernetes what will the behavior of this expose-service option ?

If we implement a --provider we could start adding provider specific options...

@kadel kadel changed the title Creating Routes for OpenShift Creating Routes for Services Sep 6, 2016
@kadel
Copy link
Member Author

kadel commented Sep 9, 2016

k8s version of Route would be Ingress object

@dustymabe
Copy link
Contributor

I still like the idea of using labels to express some of this behavior rather than adding a ton of CLI options.

@kadel
Copy link
Member Author

kadel commented Sep 28, 2016

This could be solved in similar way as #154

We decided that we are going to use labels to provide additional information for conversion.

label for this could look something like this <kompose_namespace>.service.expose: foo.bar.example.com
value can be also empty and it would mean that dns name should be constructed automatically by OpenShift.

For Kubernetes same thing should be done, but it will create Ingress object instead of Route.

@kbsingh
Copy link

kbsingh commented Sep 28, 2016

sounds good, and would resolve this issue for me.

@dustymabe
Copy link
Contributor

I believe @containscafeine has volunteered to work on this in the next few weeks. can you assign him on this ?

@dustymabe
Copy link
Contributor

@containscafeine any progress on this?

@concaf
Copy link
Contributor

concaf commented Oct 18, 2016

@dustymabe I've been trying to implement the route API from openshift/origin/pkg/route/api but hitting some issues. I will be away for some time, so I'm updating @surajssd about my progress just in case.

@kadel
Copy link
Member Author

kadel commented Oct 19, 2016

@containscafeine @surajssd If you hit any bumps just ping me I'm happy to help.

concaf added a commit to concaf/kompose that referenced this issue Dec 21, 2016
Implements a kompose specific docker compose label "kompose.service.expose" which can be used to expose the specified services externally. The accepted values are of type string.
If the value is set to "true", the provider sets the endpoint automatically, and for any other value, the value is set as the hostname. If multiple ports are defined in a service, the first one is chosen to be the exposed.

Unit tests, functional tests, glide updates and docs have also been added in this commit for the related feature.
surajssd added a commit that referenced this issue Dec 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/OpenShift kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

5 participants