Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PVCs are not created when calling kompose up #218

Closed
kadel opened this issue Oct 19, 2016 · 3 comments
Closed

PVCs are not created when calling kompose up #218

kadel opened this issue Oct 19, 2016 · 3 comments
Labels
component/Kubernetes component/OpenShift kind/bug Categorizes issue or PR as related to a bug. priority/P0

Comments

@kadel
Copy link
Member

kadel commented Oct 19, 2016

No description provided.

@kadel kadel added kind/bug Categorizes issue or PR as related to a bug. component/OpenShift component/Kubernetes labels Oct 19, 2016
@surajssd
Copy link
Member

Yes I think this is because there is no case for creating a PVC here https://github.com/kubernetes-incubator/kompose/blob/master/pkg/transformer/kubernetes/kubernetes.go#L357

@kadel
Copy link
Member Author

kadel commented Oct 19, 2016

@surajssd yes this is the reason for this, and same think in openshift.go

@kadel
Copy link
Member Author

kadel commented Oct 19, 2016

this breaks kompose for docker-compose files that are using volumes so I'm giving this P0

surajssd added a commit to surajssd/kompose that referenced this issue Oct 19, 2016
@surajssd
kompose up/down create and delete pvc
b6f7632 
pvc will be parsed when passing objects via kube client
to create various objects.
Also while deleting pvc will be deleted.

Fixes kubernetes#218
@surajssd surajssd mentioned this issue Oct 19, 2016
Merged
surajssd added a commit to surajssd/kompose that referenced this issue Oct 20, 2016
@surajssd
kompose up/down create and delete pvc
8720532 
pvc will be parsed when passing objects via kube client
to create various objects.
Also while deleting pvc will be deleted.

Fixes kubernetes#218
surajssd added a commit to surajssd/kompose that referenced this issue Oct 20, 2016
@surajssd
kompose up/down create and delete pvc
8b3bad6 
pvc will be parsed when passing objects via kube client
to create various objects.
Also while deleting pvc will be deleted.

Fixes kubernetes#218
surajssd added a commit to surajssd/kompose that referenced this issue Oct 20, 2016
@surajssd
kompose up/down create and delete pvc
ce041db 
pvc will be parsed when passing objects via kube client
to create various objects.
Also while deleting pvc will be deleted.

Fixes kubernetes#218
surajssd added a commit to surajssd/kompose that referenced this issue Oct 22, 2016
@surajssd
kompose up/down create and delete pvc
2444996 
pvc will be parsed when passing objects via kube client
to create various objects.
Also while deleting pvc will be deleted.

Fixes kubernetes#218
procrypt pushed a commit to procrypt/kompose that referenced this issue Oct 22, 2016
@surajssd @procrypt
kompose up/down create and delete pvc
e7d8866 
pvc will be parsed when passing objects via kube client
to create various objects.
Also while deleting pvc will be deleted.

Fixes kubernetes#218
cab105 pushed a commit to cab105/kompose that referenced this issue Oct 27, 2016
@surajssd @cab105
kompose up/down create and delete pvc
b7ca1b0 
pvc will be parsed when passing objects via kube client
to create various objects.
Also while deleting pvc will be deleted.

Fixes kubernetes#218
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/Kubernetes component/OpenShift kind/bug Categorizes issue or PR as related to a bug. priority/P0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kadel @surajssd