We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I'm guess that "ro" should mean read only:
https://github.com/kubernetes-incubator/kompose/blob/7435f822ed17837a4d6f472f9a0f800abe1adc95/pkg/transformer/kubernetes/kubernetes.go#L178
Should we change this to be:
diff --git a/pkg/transformer/kubernetes/kubernetes.go b/pkg/transformer/kubernetes/kubernetes.go index 6f47bdb..1ba7f38 100644 --- a/pkg/transformer/kubernetes/kubernetes.go +++ b/pkg/transformer/kubernetes/kubernetes.go @@ -175,7 +175,7 @@ func CreatePVC(name string, mode string) *api.PersistentVolumeClaim { } if mode == "ro" { - pvc.Spec.AccessModes = []api.PersistentVolumeAccessMode{"ReadWriteOnce"} + pvc.Spec.AccessModes = []api.PersistentVolumeAccessMode{"ReadOnlyMany"} } else { pvc.Spec.AccessModes = []api.PersistentVolumeAccessMode{"ReadWriteOnce"} }
The text was updated successfully, but these errors were encountered:
@dustymabe yes sure!
Sorry, something went wrong.
CreatePVC: correct setting of read/only access
f23f882
Fixes kubernetes#237
6523da8
Fixes kubernetes#237 Also update the code to use the constant values for api.ReadWriteOnce and api.ReadOnlyMany.
7d88ab3
d018219
dustymabe
No branches or pull requests
I'm guess that "ro" should mean read only:
https://github.com/kubernetes-incubator/kompose/blob/7435f822ed17837a4d6f472f9a0f800abe1adc95/pkg/transformer/kubernetes/kubernetes.go#L178
Should we change this to be:
The text was updated successfully, but these errors were encountered: