Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add coveralls #281

Closed
sebgoa opened this issue Nov 15, 2016 · 4 comments
Closed

Add coveralls #281

sebgoa opened this issue Nov 15, 2016 · 4 comments
Labels
priority/P0

Comments

@sebgoa
Copy link
Contributor

sebgoa commented Nov 15, 2016

to track our unit test coverage, we should setup coveralls.io, it is used in the main repo.

then we need to work on the unit-tests
cdrage added a commit to cdrage/kompose that referenced this issue Nov 16, 2016
@cdrage
Update TRAVIS CI to add coveralls
55f398f 
Updates travis to enable coveralls support.

Fixes kubernetes#281
@cdrage cdrage mentioned this issue Nov 16, 2016
Merged
@cdrage
Copy link
Member

cdrage commented Nov 16, 2016

@sebgoa someone will have to login to coveralls.io to enable it, but I've created #287

cdrage added a commit to cdrage/kompose that referenced this issue Nov 16, 2016
@cdrage
Update TRAVIS CI to add coveralls
c215b04 
Updates travis to enable coveralls support.

Fixes kubernetes#281
@sebgoa
Copy link
Contributor Author

sebgoa commented Nov 22, 2016

@sarahnovotny sorry to ping you directly, but do you know how we can enable coveralls for kompose. I am assuming there is a kubernetes project account.

@sebgoa
Copy link
Contributor Author

sebgoa commented Nov 22, 2016

In the meantime, I logged into coveralls and requested access for kubernetes-incubator, no clue to whom the request went. Will see.

@cdrage
Copy link
Member

cdrage commented Nov 22, 2016

@sebgoa @sarahnovotny thank you both. Yeah, the PR (#287) failed due to no access (timeout to coveralls)

cdrage added a commit to cdrage/kompose that referenced this issue Nov 29, 2016
@cdrage
Update TRAVIS CI to add coveralls
0943327 
Updates travis to enable coveralls support.

Fixes kubernetes#281
cdrage added a commit to cdrage/kompose that referenced this issue Nov 29, 2016
@cdrage
Update TRAVIS CI to add coveralls
8d0a654 
Updates travis to enable coveralls support.

Fixes kubernetes#281
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority/P0
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sebgoa @cdrage