Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

volumes_from is supported construct but conversion doc says opposite #476

Closed
surajssd opened this issue Mar 8, 2017 · 1 comment
Closed

volumes_from is supported construct but conversion doc says opposite #476

surajssd opened this issue Mar 8, 2017 · 1 comment
Labels
kind/documentation Categorizes issue or PR as related to documentation. priority/P1

Comments

@surajssd
Copy link
Member

surajssd commented Mar 8, 2017

In conversion doc its mentioned that volumes_from is unsupported which is not true.

So if I mention volumes_from in a service then in resulting conversion both the deployments/deploymentconfigs will share same PVC.
@kadel
Copy link
Member

kadel commented Mar 8, 2017 •
edited
Loading

yep, that is mistake in the conversion doc

@kadel kadel added kind/documentation Categorizes issue or PR as related to documentation. priority/P1 labels Mar 8, 2017
cdrage added a commit to cdrage/kompose that referenced this issue Mar 14, 2017
@cdrage
Add that we support volumes_from
28260fb 
Adds a note to the conversion doc that we support volumes_from.

Closes kubernetes#476
@cdrage cdrage mentioned this issue Mar 14, 2017
Merged
procrypt pushed a commit to procrypt/kompose that referenced this issue Mar 20, 2017
@cdrage @procrypt
Add that we support volumes_from
62df90c 
Adds a note to the conversion doc that we support volumes_from.

Closes kubernetes#476
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/documentation Categorizes issue or PR as related to documentation. priority/P1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kadel @surajssd