Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused functions in app.go and utils.go #534

Closed
surajnarwade opened this issue Apr 3, 2017 · 2 comments
Closed

Unused functions in app.go and utils.go #534

surajnarwade opened this issue Apr 3, 2017 · 2 comments

Comments

@surajnarwade
Copy link
Contributor

functions askForConfirmation in app.go, TransformData and RandStringBytes in utils.go are not called anywhere in kompose, shall we remove them or they are there for any purpose ?
@surajssd
Copy link
Member

surajssd commented Apr 3, 2017

@surajnarwade yes if that is the case we remove it, do you wanna give it a stab?

@surajnarwade
Copy link
Contributor Author

@surajssd yeah

surajnarwade added a commit to surajnarwade/kompose that referenced this issue Apr 4, 2017
@surajnarwade
Removed unused functions
3a086b4 
Fixes kubernetes#534 by removing functions askForConfirmation in app.go, TransformData and RandStringBytes in utils.go
@surajnarwade surajnarwade mentioned this issue Apr 4, 2017
Merged
@kadel kadel closed this as completed in #539 Apr 6, 2017
qujinping pushed a commit to qujinping/kompose that referenced this issue Apr 25, 2017
@surajnarwade
Removed unused functions
32b44dc 
Fixes kubernetes#534 by removing functions askForConfirmation in app.go, TransformData and RandStringBytes in utils.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@surajssd @surajnarwade