Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for 'pid' key #610

Closed
gitlawr opened this issue May 18, 2017 · 4 comments
Closed

Add support for 'pid' key #610

gitlawr opened this issue May 18, 2017 · 4 comments

Comments

@gitlawr
Copy link
Contributor

gitlawr commented May 18, 2017

In compose file, pid key is merely used to set the PID mode to the host PID mode (and no support for pid=container:id). Therefore I think it can be converted to Pod.Spec.HostPid in K8s.
@surajnarwade
Copy link
Contributor

@gitlawr , but k8s spec is boolean here

@gitlawr
Copy link
Contributor Author

gitlawr commented May 18, 2017

yes, but it seems to be the same in compose file, you choose pid='host' or not

@surajnarwade
Copy link
Contributor

@surajssd @kadel thoughts ?

@cdrage
Copy link
Member

cdrage commented May 18, 2017

It should be fine.. if pid=="host make the boolean true in k8s...

gitlawr added a commit to gitlawr/kompose that referenced this issue May 24, 2017
@gitlawr
add support for "pid" key
1a8519d 
solve kubernetes#610
convert service.pid to Pod.Spec.HostPid
set Pod.Spec.HostPid to true if service.pid ="host", to false otherwise
update conversion.md on support for the key
@gitlawr gitlawr mentioned this issue May 24, 2017
Merged
gitlawr added a commit to gitlawr/kompose that referenced this issue May 31, 2017
@gitlawr
add support for "pid" key
1485ed4 
solve kubernetes#610
convert service.pid to Pod.Spec.HostPid
set Pod.Spec.HostPid to true if service.pid ="host", to false otherwise
update conversion.md on support for the key
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gitlawr @cdrage @surajnarwade