Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Up and convert commands are not equal in features #798

Closed
3 of 8 tasks
cdrage opened this issue Aug 25, 2017 · 4 comments
Closed
3 of 8 tasks

Up and convert commands are not equal in features #798

cdrage opened this issue Aug 25, 2017 · 4 comments
Assignees
@surajnarwade

Comments

@cdrage
Copy link
Member

cdrage commented Aug 25, 2017 •
edited by surajnarwade
Loading

For example, we are able to deploy --daemon-set using convert, but not with up.

We have some things such as --build which is consistent in kompose up, but other aspects such as controllers, etc do not function correctly.

We should have the SAME experience between up and convert.

It goes against UX/UI having inconsistencies between the commands. One should convert, one should bring those converted up.

List of parameters NOT in up:

  • --daemon-set
  • --deployment
  • --chart (I don't think this should be applicable)
  • --replication-controller
  • --build-branch
  • --build-repo
  • --deployment-config
  • --insecure-repository

A couple of these parameters will be deprecated in favour of --controller however.
@cdrage cdrage changed the title kompose up and kompose convert is not consistent kompose up and kompose commands are not equal in features Aug 25, 2017
@cdrage cdrage changed the title kompose up and kompose commands are not equal in features Up and convert commands are not equal in features Aug 25, 2017
@surajnarwade
Copy link
Contributor

Picking --build-branch first

@surajnarwade
Copy link
Contributor

sending PR for --build-repo

@surajnarwade
Copy link
Contributor

--build-repo is being tracked in PR #824
--build-branch is being tracked in PR #820

This was referenced Sep 26, 2017
Merged
Merged
@surajnarwade surajnarwade self-assigned this Sep 27, 2017
@surajnarwade surajnarwade added this to the 1.3.0 release milestone Sep 27, 2017
@surajnarwade
Copy link
Contributor

surajnarwade commented Oct 10, 2017 •
edited
Loading

if we are adding --controller and controller flags like --daemon-set, --replication-controller, we have to implement in kompose down as well
@cdrage thoughts ?

@cdrage cdrage modified the milestones: 1.3.0 release, 1.4.0 release Oct 10, 2017
@cdrage cdrage modified the milestones: 1.4.0 release, 1.5.0 release Oct 31, 2017
surajnarwade added a commit to surajnarwade/kompose that referenced this issue Nov 14, 2017
@surajnarwade
Adding --controller flag in up & down
c061f05 
To make `kompose up` & `kompose convert` equal in feature, This PR will
add `--controller` flag for `kompose up` as well as `kompose down`
so that user experience will be the same for `up` & `convert`
Resolves kubernetes#798
@surajnarwade surajnarwade mentioned this issue Nov 14, 2017
Merged
surajnarwade added a commit to surajnarwade/kompose that referenced this issue Nov 21, 2017
@surajnarwade
Adding --controller flag in up & down
9308b06 
To make `kompose up` & `kompose convert` equal in feature, This PR will
add `--controller` flag for `kompose up` as well as `kompose down`
so that user experience will be the same for `up` & `convert`
Resolves kubernetes#798

since we are adding `--controller` to `up` and `down`, So respective code to deploy and undeploy also being added for `daemonset` and `replicationcontroller`
surajnarwade added a commit to surajnarwade/kompose that referenced this issue Nov 27, 2017
@surajnarwade
Adding --controller flag in up & down
126d982 
To make `kompose up` & `kompose convert` equal in feature, This PR will
add `--controller` flag for `kompose up` as well as `kompose down`
so that user experience will be the same for `up` & `convert`
Resolves kubernetes#798

since we are adding `--controller` to `up` and `down`, So respective code to deploy and undeploy also being added for `daemonset` and `replicationcontroller`

Added tests for `--controller`
procrypt pushed a commit to procrypt/kompose that referenced this issue Feb 4, 2018
@surajnarwade @procrypt
Adding --controller flag in up & down
3d7d3a9 
To make `kompose up` & `kompose convert` equal in feature, This PR will
add `--controller` flag for `kompose up` as well as `kompose down`
so that user experience will be the same for `up` & `convert`
Resolves kubernetes#798

since we are adding `--controller` to `up` and `down`, So respective code to deploy and undeploy also being added for `daemonset` and `replicationcontroller`

Added tests for `--controller`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@surajnarwade surajnarwade

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cdrage @surajnarwade