Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add warnings/error for image not specified #80

Closed
janetkuo opened this issue Aug 3, 2016 · 3 comments
Closed

Add warnings/error for image not specified #80

janetkuo opened this issue Aug 3, 2016 · 3 comments

Comments

@janetkuo
Copy link
Member

janetkuo commented Aug 3, 2016

Follow-up #79 (comment):

image is a required field in Kubernetes and without it the generated file can't be used.

From compose spec, v1 doesn't allow image being specified with build, and v2 allows you to do that but the image will be built from build.

We can print an error when we see build in the compose file. Would love to hear more thoughts.

@surajssd
Copy link
Member

surajssd commented Aug 6, 2016

With Kubernetes:

  • image is must, until we come up with a build story

With OpenShift:

  • If build given we can create buildconfig
  • if image given well and good

cc: @kadel

@ngtuna
Copy link
Contributor

ngtuna commented Aug 10, 2016

Currently there is an unsupported key message if we see build in the compose file.
@surajssd : while working on the issue #92 of having image and build in the same compose service, you can also add a check for required fields like image

@ngtuna
Copy link
Contributor

ngtuna commented Oct 10, 2016

Closed via #195

@ngtuna ngtuna closed this as completed Oct 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants