Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable warnings in stdout #79

Merged
merged 1 commit into from
Aug 4, 2016

Conversation

janetkuo
Copy link
Member

@janetkuo janetkuo commented Aug 3, 2016

Ref #71

With this change, you see warnings even when --stdout is specified:

$ kompose convert -f docker-voting.yml -y --stdout | kubectl create -f - 
time="2016-08-03T11:39:37-07:00" level=warning msg="Unsupported key build - ignoring" 
time="2016-08-03T11:39:37-07:00" level=warning msg="Unsupported key networks - ignoring" 
time="2016-08-03T11:39:37-07:00" level=warning msg="[worker] Service cannot be created because of missing port." 
time="2016-08-03T11:39:37-07:00" level=warning msg="[db] Service cannot be created because of missing port." 
service "redis" created
service "result" created
service "vote" created
deployment "db" created
deployment "redis" created
Error from server: error when creating "STDIN": Deployment.extensions "vote" is invalid: spec.template.spec.containers[0].image: Required value
Error from server: error when creating "STDIN": Deployment.extensions "worker" is invalid: spec.template.spec.containers[0].image: Required value
Error from server: error when creating "STDIN": Deployment.extensions "result" is invalid: spec.template.spec.containers[0].image: Required value

@janetkuo
Copy link
Member Author

janetkuo commented Aug 3, 2016

However we need to solve this in a separate PR/issue; filed #80

Error from server: error when creating "STDIN": Deployment.extensions "vote" is invalid: spec.template.spec.containers[0].image: Required value
Error from server: error when creating "STDIN": Deployment.extensions "worker" is invalid: spec.template.spec.containers[0].image: Required value
Error from server: error when creating "STDIN": Deployment.extensions "result" is invalid: spec.template.spec.containers[0].image: Required value

@ngtuna
Copy link
Contributor

ngtuna commented Aug 4, 2016

Ah... so it means we can still print warning message and the pipeline ignores it... So actually my previous commit 72fc1a2 is unnecessary...

@ngtuna ngtuna added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 4, 2016
@janetkuo
Copy link
Member Author

janetkuo commented Aug 4, 2016

Yes, I believe those warnings are printed to stderr so it won't mingle with real output

@janetkuo janetkuo merged commit 2010cef into kubernetes:master Aug 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants