Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix function comments based on best practices from Effective Go #1112

Merged
merged 1 commit into from Mar 20, 2019
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions pkg/transformer/utils.go
Expand Up @@ -176,12 +176,12 @@ func formatProviderName(provider string) string {
// EnvSort struct
type EnvSort []api.EnvVar

// returns the number of elements in the collection.
// Len returns the number of elements in the collection.
func (env EnvSort) Len() int {
return len(env)
}

// returns whether the element with index i should sort before
// Less returns whether the element with index i should sort before
// the element with index j.
func (env EnvSort) Less(i, j int) bool {
return env[i].Name < env[j].Name
Expand Down