New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
actually use normalizeNetworkNames to produce valid network names #1393
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @exokortex! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: exokortex The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
0fc08da
to
7dc3756
Compare
/help |
7dc3756
to
108cdbe
Compare
not related go module error, will fix it after merged this PR |
Thanks @exokortex |
Currently kompose does not normalize network names, which can lead to networks containing invalid characters for Kubernetes NetworkPolicy resources. There already was a function for this in
pkg/loader/compose/utils.go
, but it was not used.