Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix golang.org/x/net vendoring #199

Merged
merged 1 commit into from
Oct 11, 2016
Merged

fix golang.org/x/net vendoring #199

merged 1 commit into from
Oct 11, 2016

Conversation

kadel
Copy link
Member

@kadel kadel commented Oct 11, 2016

fixes golang.org/x/net vendoring
it was vendored with reference to 2beffdc2e92c8a3027590f898fe88f69af48a3f8
but this is not a reference to golang.org/x/net instead it is reference in fork https://github.com/tonistiigi/net.git

This was caused by libcompose. (https://github.com/docker/libcompose/blob/master/hack/vendor.sh#L23)

cc: @ngtuna

Copy link
Contributor

@ngtuna ngtuna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested. script/godep-restore.sh run successfully.

@ngtuna ngtuna added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2016
@kadel kadel merged commit 51ef336 into kubernetes:master Oct 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged. review needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants