add golint check to travis-ci #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
ping us when this is ready. |
|
it will take a while :-( |
kadel
force-pushed
the
golint
branch
3 times, most recently
from
1593601
to
9077875
Compare
surajssd
reviewed
Jan 5, 2017
| @@ -24,6 +24,7 @@ import ( | |||
| "github.com/spf13/cobra" | |||
| ) | |||
|
|
|||
| // TODO: comment | |||
There was a problem hiding this comment.
Do you plan to add this comment or do you want someone else to do it?
There was a problem hiding this comment.
It would be great if someone else do it (ideally authors of those functions).
I just put it there so golint is not complaining and we can merge it and start checking new PRs.
ngtuna
approved these changes
Jan 5, 2017
|
@kadel cool LGTM |
surajssd
approved these changes
Jan 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds golint check to travis.
Golint checks coding standart rules from Effective Go and the CodeReviewComments wiki page.
Sometimes it can be quite strict and annoying, but I think that we should try it, and see how it goes.
This PR also fixes all the golint errors in the current code.