Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flag validation called on up and down #347

Merged
merged 1 commit into from Dec 27, 2016
Merged

Flag validation called on up and down #347

merged 1 commit into from Dec 27, 2016

Conversation

surajssd
Copy link
Member

On kompose up and kompose down flag validation
was done which is validating flags that are not there
in kompose up and kompose down

@surajssd
Flag validation called on up and down
5625a97 
On kompose up and kompose down flag validation
was done which is validating flags that are not there
in kompose up and kompose down
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 27, 2016
@coveralls
Copy link

Coverage Status

Coverage remained the same at 45.739% when pulling 5625a97 on surajssd:up_down_no_validation_needed into 7341831 on kubernetes-incubator:master.

@surajssd surajssd requested a review from rtnpro December 27, 2016 11:20
rtnpro
rtnpro approved these changes Dec 27, 2016
View reviewed changes
Copy link
Contributor

@rtnpro rtnpro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

pradeepto
pradeepto approved these changes Dec 27, 2016
View reviewed changes
Copy link

@pradeepto pradeepto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@surajssd
Copy link
Member Author

@pradeepto thanks 👍

@surajssd surajssd merged commit 0370d66 into kubernetes:master Dec 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pradeepto pradeepto pradeepto approved these changes

@rtnpro rtnpro rtnpro approved these changes

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@surajssd @coveralls @pradeepto @rtnpro @k8s-ci-robot