-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add deploy/undeploy pod only #363
Conversation
@ngtuna because you added new lines that are not covered by tests :-) |
@kadel oh now I got it. Test is coming up. |
@ngtuna I'm not sure if this can be currently tested properly without mocking kubernetes :-( or starting cluster. |
@kadel Right. I made this commit last night but then came up with no idea how to add a test. Will investigate it more late today. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same thing should be added to OpenShift transformer
@kadel I added commit for OpenShift |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT
We have to figure out how to test up/down automatically , but that is another issue.
ref: #342
Ping @surajssd @kadel