Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add deploy/undeploy pod only #363

Merged
merged 2 commits into from
Jan 11, 2017
Merged

add deploy/undeploy pod only #363

merged 2 commits into from
Jan 11, 2017

Conversation

ngtuna
Copy link
Contributor

@ngtuna ngtuna commented Jan 5, 2017

ref: #342

Ping @surajssd @kadel

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 5, 2017
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 46.163% when pulling 162ae3e on ngtuna:up-down-pod into 6e260ba on kubernetes-incubator:master.

@ngtuna
Copy link
Contributor Author

ngtuna commented Jan 6, 2017

@surajssd @kadel Do you have idea why my PR pulling down the coveralls ? :-(

@kadel
Copy link
Member

kadel commented Jan 6, 2017

@ngtuna because you added new lines that are not covered by tests :-)

@ngtuna
Copy link
Contributor Author

ngtuna commented Jan 6, 2017

@kadel oh now I got it. Test is coming up.

@kadel
Copy link
Member

kadel commented Jan 6, 2017

@ngtuna I'm not sure if this can be currently tested properly without mocking kubernetes :-( or starting cluster.
But it would be great if you have any idea how to do it.
Otherwise I wouldn't worry about in this PR. We will have to figure out a way how to test up for everything later.

@ngtuna
Copy link
Contributor Author

ngtuna commented Jan 6, 2017

@kadel Right. I made this commit last night but then came up with no idea how to add a test. Will investigate it more late today.

Copy link
Member

@kadel kadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing should be added to OpenShift transformer

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 46.57% when pulling fa8157a on ngtuna:up-down-pod into 7dbf00c on kubernetes-incubator:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.9%) to 46.141% when pulling 5e59400 on ngtuna:up-down-pod into 7dbf00c on kubernetes-incubator:master.

@ngtuna
Copy link
Contributor Author

ngtuna commented Jan 10, 2017

@kadel I added commit for OpenShift

Copy link
Member

@kadel kadel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

We have to figure out how to test up/down automatically , but that is another issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. rebase needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants