Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified user-guide on kompose.io #480

Merged
merged 1 commit into from
Mar 10, 2017

Conversation

surajnarwade
Copy link
Contributor

Fixes #479

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 9, 2017
@kadel
Copy link
Member

kadel commented Mar 9, 2017

I have stupid question 😊 Do we even need this list here? Is this duplicating what is already in conversion.md

I think we can just link to that document. It will be easier to keep it in one place

@cdrage
Copy link
Member

cdrage commented Mar 9, 2017

I agree with @kadel :)

@surajnarwade
Copy link
Contributor Author

@cdrage @kadel , I thought of updating list on kompose.io

@cdrage
Copy link
Member

cdrage commented Mar 9, 2017

@surajnarwade @kadel

Yes, what @kadel is saying is removing it from both docs/user-guide.md in master as well as in gh-pages.

@kadel
Copy link
Member

kadel commented Mar 9, 2017

Yes, what @kadel is saying is removing it from both docs/user-guide.md in master as well as in gh-pages.

yes, and replacing it with link to conversion table

@surajnarwade
Copy link
Contributor Author

got it :)

```
"build", "cgroup_parent", "devices", "depends_on", "dns", "dns_search", "domainname", "env_file", "extends", "external_links", "extra_hosts", "hostname", "ipc", "logging", "mac_address", "mem_limit", "memswap_limit", "network_mode", "networks", "pid", "security_opt", "shm_size", "stop_signal", "volume_driver", "uts", "read_only", "stdin_open", "tty", "user", "ulimits", "dockerfile", "net"
```
Currently `kompose` does not support some of the Docker Compose options, which are listed on [conversion](http://kompose.io/conversion/) page.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some Docker Compose options

listed on the conversion document

@cdrage
Copy link
Member

cdrage commented Mar 10, 2017

Oh, and update the commit message as well please!

@surajnarwade surajnarwade changed the title Modified unsupported keys Modified user-guide on kompose.io Mar 10, 2017
@surajnarwade
Copy link
Contributor Author

@cdrage , updated both

@cdrage
Copy link
Member

cdrage commented Mar 10, 2017

@surajnarwade Thanks, the git commit message still isn't modified however.

modified user-guide as it will point to conversion document for unsupported
docker-compose options
@surajnarwade
Copy link
Contributor Author

@cdrage , my bad, updated now :)

@cdrage
Copy link
Member

cdrage commented Mar 10, 2017

LGTM! 👍

@cdrage cdrage merged commit add5a04 into kubernetes:gh-pages Mar 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants