Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move docker-compose.yml test file to tests #531

Merged
merged 1 commit into from
Apr 6, 2017

Conversation

cdrage
Copy link
Member

@cdrage cdrage commented Mar 31, 2017

Moves a file that was incorrectly being used from examples to
script/test/fixtures.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 31, 2017
@cdrage
Copy link
Member Author

cdrage commented Mar 31, 2017

Unblocks #528

@kadel
Copy link
Member

kadel commented Apr 3, 2017

it might be better to move script/test/docker-compose.yml to its own directory in fixtures so its inline with other tests

@cdrage
Copy link
Member Author

cdrage commented Apr 3, 2017

@kadel Done! Moved it to redis-example.

Moves a file that was incorrectly being used from examples to
script/test/fixtures.
@cdrage
Copy link
Member Author

cdrage commented Apr 4, 2017

There, tests should pass now!

@cdrage cdrage mentioned this pull request Apr 4, 2017
@cdrage
Copy link
Member Author

cdrage commented Apr 6, 2017

Woo 👍

@cdrage cdrage merged commit db7bfcf into kubernetes:master Apr 6, 2017
@cdrage cdrage deleted the move-to-proper-test-dir branch April 19, 2017 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants