Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only ignore the docker-compose yaml file in the root directory #533

Merged
merged 1 commit into from Apr 11, 2017

Conversation

cdrage
Copy link
Member

@cdrage cdrage commented Mar 31, 2017

Woops! It was ignoring all of them in the directory. We should only be
avoiding the root dir docker-compose files!

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 31, 2017
@surajnarwade
Copy link
Contributor

LGTM 👍

@kadel
Copy link
Member

kadel commented Apr 3, 2017

examples/docker-compose.yaml and script/test/fixtures/docker-compose.yml were deleted before? What are those? Maybe leftovers from #528 ?

Woops! It was ignoring all of them in the directory. We should only be
avoiding the root dir docker-compose files!
@cdrage
Copy link
Member Author

cdrage commented Apr 10, 2017

@kadel Yup, they were, I rebased and removed them.

@kadel kadel merged commit 8f435b1 into kubernetes:master Apr 11, 2017
@cdrage cdrage deleted the woops-gitignore branch May 26, 2017 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants