Updated Vendoring #601
Merged
Updated Vendoring #601
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It resolves issues kubernetes#474 and kubernetes#589 which were coming from libcompose, as well as resolves kubernetes#440 and kubernetes#437 partially as `group_add` & `stop_grace_period` are supported by libcompose now.
k8s-ci-robot
added
the
cncf-cla: yes
|
LGTM! 👍 |
surajssd
approved these changes
May 15, 2017
|
@surajnarwade also comment on each issue you mentioned with the their failing example if it is passing? Also why do you say #440 and #437 is partially fixed? |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It resolves issues #474 and #589 which were coming from libcompose,
as well as resolves #440 and #437 partially as
group_add&stop_grace_periodare supported by libcompose now.