Update cluster tests, use local Kompose binary #757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
cdrage
force-pushed
the
update-cluster-tests-again-part-two
branch
from
3379fd6
to
b607cb5
Compare
Uses the local kompose binary that was built, not the one stored in the GOPATH bin folder. For example, using `./kompose` instead of `kompose`. Disables `make bin` generation for Kubernetes tests.
cdrage
force-pushed
the
update-cluster-tests-again-part-two
branch
from
b607cb5
to
e89e41b
Compare
|
Hey @ashetty1 I'm going to merge this for now in order to make any new PR's pass for the cluster tests, let me know if this conflicts with anything. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the local kompose binary that was built, not the one stored in the
GOPATH bin folder.
For example, using
./komposeinstead ofkomposeDisables
make bingeneration for Kubernetes tests.