Fix pushing of image to a private repository

[Code0x58]

This is to test and fix #893

p.s. The existing tests/platform flaked on OpenShift

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://github.com/kubernetes/kubernetes/wiki/CLA-FAQ to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please email the CNCF helpdesk: helpdesk@rt.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[Code0x58]

I finally got this sorted, the issue with using the default registry was that it wasn't available by the time the docker login was running, this generally wouldn't have been an issue for tests as the pods would fail to pull and then back off before retrying, usually not exceeding the test's timeout.

The issue is reproduced in tests; I don't feel Semaphore CI is doing the tests properly, as it shows the first commit as passing although it doesn't. I am wondering if it has ran the HEAD of the PR twice instead of running each commit in the PR.

Bonus: I think this change will reduce the odds of the first test timing out.

[cdrage]

Holy moley. Good test coverage 👍

I see absolutely nothing wrong with the code. Thank you for covering everything from integration to unit tests.

Tests pass, code looks good, LGTM 👍

[cdrage]

@kadel @surajnarwade second look?

[cdrage]

I'd like to get this in for this month's release, so I'm going to merge it in 👍 Thanks a lot @Code0x58 for the PR!